Update patch set 7
Patch Set 7: Code-Review-1 (6 comments) Patch-set: 7 Reviewer: Gerrit User 29740 <29740@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
Gerrit User 29740
Gerrit Code Review
parent
18ed844b5e
commit
bc8a336732
|
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_e4505b0d",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 105,
|
||||
"author": {
|
||||
"id": 29740
|
||||
},
|
||||
"writtenOn": "2019-01-23T17:09:24Z",
|
||||
"side": 1,
|
||||
"message": "i\u0027ll fix this.",
|
||||
"parentUuid": "9fdfeff1_6cac698c",
|
||||
"range": {
|
||||
"startLine": 105,
|
||||
"startChar": 32,
|
||||
"endLine": 105,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_cc9f954e",
|
||||
|
|
@ -46,6 +70,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_84570f03",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 119,
|
||||
"author": {
|
||||
"id": 29740
|
||||
},
|
||||
"writtenOn": "2019-01-23T17:09:24Z",
|
||||
"side": 1,
|
||||
"message": "i\u0027ll fix this.",
|
||||
"parentUuid": "9fdfeff1_cc9f954e",
|
||||
"range": {
|
||||
"startLine": 119,
|
||||
"startChar": 32,
|
||||
"endLine": 119,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_0c9efd55",
|
||||
|
|
@ -69,6 +117,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_a45a5327",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 173,
|
||||
"author": {
|
||||
"id": 29740
|
||||
},
|
||||
"writtenOn": "2019-01-23T17:09:24Z",
|
||||
"side": 1,
|
||||
"message": "i\u0027ll fix this.",
|
||||
"parentUuid": "9fdfeff1_0c9efd55",
|
||||
"range": {
|
||||
"startLine": 173,
|
||||
"startChar": 32,
|
||||
"endLine": 173,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_8ca98d7c",
|
||||
|
|
@ -92,6 +164,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_643c6bbf",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 191,
|
||||
"author": {
|
||||
"id": 29740
|
||||
},
|
||||
"writtenOn": "2019-01-23T17:09:24Z",
|
||||
"side": 1,
|
||||
"message": "i\u0027ll fix this.",
|
||||
"parentUuid": "9fdfeff1_8ca98d7c",
|
||||
"range": {
|
||||
"startLine": 191,
|
||||
"startChar": 32,
|
||||
"endLine": 191,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_4ce2c5d7",
|
||||
|
|
@ -115,6 +211,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_84a5cf06",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_log_retrieval.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 36,
|
||||
"author": {
|
||||
"id": 29740
|
||||
},
|
||||
"writtenOn": "2019-01-23T17:09:24Z",
|
||||
"side": 1,
|
||||
"message": "Since we are not worried about log content I am planning to remove the assert. Will that be OK?",
|
||||
"parentUuid": "9fdfeff1_4ce2c5d7",
|
||||
"range": {
|
||||
"startLine": 21,
|
||||
"startChar": 0,
|
||||
"endLine": 36,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_6cf309a0",
|
||||
|
|
@ -137,6 +257,30 @@
|
|||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_248d037b",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_site_statuses.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 41,
|
||||
"author": {
|
||||
"id": 29740
|
||||
},
|
||||
"writtenOn": "2019-01-23T17:09:24Z",
|
||||
"side": 1,
|
||||
"message": "I am not sure how to address this, can you please guide here?",
|
||||
"parentUuid": "9fdfeff1_6cf309a0",
|
||||
"range": {
|
||||
"startLine": 41,
|
||||
"startChar": 12,
|
||||
"endLine": 41,
|
||||
"endChar": 72
|
||||
},
|
||||
"revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue