Update patch set 7

Patch Set 7: Code-Review-1

(6 comments)

On one hand, I think this is a useful harness, and only have a few comments regarding things to consider/change. 

On the other hand, I agree with Filipe's comment about this not being a reliable way to functional test, as it will skip many scenarios when they haven't been set up.

Patch-set: 7
Reviewer: Gerrit User 26365 <26365@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822

@@ -0,0 +1,142 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9fdfeff1_6cac698c",
+        "filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 105,
+      "author": {
+        "id": 26365
+      },
+      "writtenOn": "2019-01-22T19:04:05Z",
+      "side": 1,
+      "message": "deployment",
+      "range": {
+        "startLine": 105,
+        "startChar": 32,
+        "endLine": 105,
+        "endChar": 41
+      },
+      "revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_cc9f954e",
+        "filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 119,
+      "author": {
+        "id": 26365
+      },
+      "writtenOn": "2019-01-22T19:04:05Z",
+      "side": 1,
+      "message": "deployment",
+      "range": {
+        "startLine": 119,
+        "startChar": 32,
+        "endLine": 119,
+        "endChar": 41
+      },
+      "revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_0c9efd55",
+        "filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 173,
+      "author": {
+        "id": 26365
+      },
+      "writtenOn": "2019-01-22T19:04:05Z",
+      "side": 1,
+      "message": "deployment",
+      "range": {
+        "startLine": 173,
+        "startChar": 32,
+        "endLine": 173,
+        "endChar": 41
+      },
+      "revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_8ca98d7c",
+        "filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 191,
+      "author": {
+        "id": 26365
+      },
+      "writtenOn": "2019-01-22T19:04:05Z",
+      "side": 1,
+      "message": "deployment",
+      "range": {
+        "startLine": 191,
+        "startChar": 32,
+        "endLine": 191,
+        "endChar": 41
+      },
+      "revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_4ce2c5d7",
+        "filename": "airship_tempest_plugin/tests/api/shipyard/test_log_retrieval.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 36,
+      "author": {
+        "id": 26365
+      },
+      "writtenOn": "2019-01-22T19:04:05Z",
+      "side": 1,
+      "message": "The logs for actions are cleaned up after a time period (I think 30 days). It\u0027s possible that if the action is too old it will not return logs.",
+      "range": {
+        "startLine": 21,
+        "startChar": 0,
+        "endLine": 36,
+        "endChar": 56
+      },
+      "revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fdfeff1_6cf309a0",
+        "filename": "airship_tempest_plugin/tests/api/shipyard/test_site_statuses.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 41,
+      "author": {
+        "id": 26365
+      },
+      "writtenOn": "2019-01-22T19:04:05Z",
+      "side": 1,
+      "message": "This should be ok for any real site, but in a single node/genesis only installation, this will likely fail. Same comment on other places that [0] is assumed to exist.",
+      "range": {
+        "startLine": 41,
+        "startChar": 12,
+        "endLine": 41,
+        "endChar": 72
+      },
+      "revId": "04d58a9c038c5ca2a6cf0c8548f2e4d1b51f1822",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}