airship
/
armada
Code Issues Proposed changes

Fix `test:` key behavior for chart definitions 

Currently armada will execute tests and implement a wait condition
on any chart with a non-false value for the `test:` key. This
makes the check for the value only execute tests for a chart when
the value is set to true

For issue, see: https://github.com/att-comdev/armada/issues/190

Change-Id: I1591f7f4c652e253c0d97f2a78c4733848687944
This commit is contained in:
Steve Wilkerson 2018-01-25 14:16:12 -06:00
parent 1a9d2e747a
commit 62338b394f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
armada/handlers/armada.py
View File

@ -235,7 +235,7 @@ class Armada(object):
if chart.release is None:
continue
if test_chart:
if test_chart is True:
chart_wait = True
# retrieve appropriate timeout value if 'wait' is specified
@ -343,7 +343,7 @@ class Armada(object):
LOG.debug("Cleaning up chart source in %s",
chartbuilder.source_directory)
if test_charts or test_chart:
if test_charts or (test_chart is True):
LOG.info('Testing: %s', prefix_chart)
resp = self.tiller.testing_release(prefix_chart)
test_status = getattr(resp.info.status,