From 62338b394f0f0958fe9da9c176e1110651975601 Mon Sep 17 00:00:00 2001 From: Steve Wilkerson Date: Thu, 25 Jan 2018 14:16:12 -0600 Subject: [PATCH] Fix `test:` key behavior for chart definitions Currently armada will execute tests and implement a wait condition on any chart with a non-false value for the `test:` key. This makes the check for the value only execute tests for a chart when the value is set to true For issue, see: https://github.com/att-comdev/armada/issues/190 Change-Id: I1591f7f4c652e253c0d97f2a78c4733848687944 --- armada/handlers/armada.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/armada/handlers/armada.py b/armada/handlers/armada.py index 0c1abd21..dace9955 100644 --- a/armada/handlers/armada.py +++ b/armada/handlers/armada.py @@ -235,7 +235,7 @@ class Armada(object): if chart.release is None: continue - if test_chart: + if test_chart is True: chart_wait = True # retrieve appropriate timeout value if 'wait' is specified @@ -343,7 +343,7 @@ class Armada(object): LOG.debug("Cleaning up chart source in %s", chartbuilder.source_directory) - if test_charts or test_chart: + if test_charts or (test_chart is True): LOG.info('Testing: %s', prefix_chart) resp = self.tiller.testing_release(prefix_chart) test_status = getattr(resp.info.status,