airship
/
specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
Reviewer: Gerrit User 10366 <10366@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 10366 2019-03-12 05:28:58 +00:00 committed by Gerrit Code Review
parent 1e51f6f99f
commit 937df15d6d
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20
View File

@ -465,6 +465,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_aa0c243b",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 4
},
"lineNbr": 131,
"author": {
"id": 10366
},
"writtenOn": "2019-03-12T05:28:58Z",
"side": 1,
"message": "Yes the Drydock Node driver can be specified as part of drydock conf file. Configuration parameter to use - https://github.com/openstack/airship-drydock/blob/master/python/drydock_provisioner/config.py#L168",
"parentUuid": "9fdfeff1_6e1f9309",
"range": {
"startLine": 129,
"startChar": 0,
"endLine": 131,
"endChar": 70
},
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_daa19548",
@ -488,6 +512,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_2a5034d4",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 4
},
"lineNbr": 147,
"author": {
"id": 10366
},
"writtenOn": "2019-03-12T05:28:58Z",
"side": 1,
"message": "Ironic is not expected to setup and configure switches. In this step the network subnets, vlans, any dhcp helpers (already configured on switch) information will be passed onto the provisioner, ironic in this case.\nYes the pxe network details need to be part of manifest definitions.",
"parentUuid": "9fdfeff1_daa19548",
"range": {
"startLine": 147,
"startChar": 0,
"endLine": 147,
"endChar": 79
},
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_5a8da5d1",
@ -534,6 +582,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_aa5ae426",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 4
},
"lineNbr": 152,
"author": {
"id": 10366
},
"writtenOn": "2019-03-12T05:28:58Z",
"side": 1,
"message": "Today this is part of single function. In Drydock Node driver MAAS, firmware updates,RAID configuration is not supported.",
"parentUuid": "9fdfeff1_5aa60556",
"range": {
"startLine": 150,
"startChar": 0,
"endLine": 152,
"endChar": 31
},
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_ba6a91ea",
@ -604,6 +676,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_aaf664f8",
"filename": "specs/approved/drydock_ironic_integration.rst",
"patchSetId": 4
},
"lineNbr": 203,
"author": {
"id": 10366
},
"writtenOn": "2019-03-12T05:28:58Z",
"side": 1,
"message": "OOB is used today to set bootdev to pxe mode and do power cycle operations. If Ironic handles them then as per Scott suggestion, we can make OOB driver as noop.",
"parentUuid": "5fc1f717_eb2b1be8",
"range": {
"startLine": 203,
"startChar": 48,
"endLine": 203,
"endChar": 75
},
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_3a7ea1af",