Update patch set 4
Patch Set 4: (6 comments) Patch-set: 4 Reviewer: Gerrit User 9542 <9542@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
Gerrit User 9542
Gerrit Code Review
parent
d54caaacdc
commit
1e51f6f99f
|
|
@ -325,6 +325,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_cb873f0f",
|
||||
"filename": "specs/approved/drydock_ironic_integration.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 93,
|
||||
"author": {
|
||||
"id": 9542
|
||||
},
|
||||
"writtenOn": "2019-03-11T18:13:53Z",
|
||||
"side": 1,
|
||||
"message": "in order for PXE to work DHCP response must contain proper options for (i)PXE pointing to the TFTP/HTTP server that _particular_ ironic conductor manages (the one that currently manages this given node that is booted).\n\nin integrated case (with Neutron) ironic\u0027s dhcp and networking drivers actively manage DHCP options for PXE (and optionally MAC address) on the neutron port assigned by nova to this given node.\n\nIn standalone case w/o Neutron there must be other way, discussed below.",
|
||||
"parentUuid": "9fdfeff1_7ad8a9ef",
|
||||
"range": {
|
||||
"startLine": 92,
|
||||
"startChar": 3,
|
||||
"endLine": 93,
|
||||
"endChar": 55
|
||||
},
|
||||
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_b472afaf",
|
||||
|
|
@ -348,6 +372,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_8b9e1752",
|
||||
"filename": "specs/approved/drydock_ironic_integration.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 101,
|
||||
"author": {
|
||||
"id": 9542
|
||||
},
|
||||
"writtenOn": "2019-03-11T18:13:53Z",
|
||||
"side": 1,
|
||||
"message": "for now we propose static nginx/apache with all the required images placed there.",
|
||||
"parentUuid": "9fdfeff1_b472afaf",
|
||||
"range": {
|
||||
"startLine": 101,
|
||||
"startChar": 42,
|
||||
"endLine": 101,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_faed798e",
|
||||
|
|
@ -532,6 +580,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_eb2b1be8",
|
||||
"filename": "specs/approved/drydock_ironic_integration.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 203,
|
||||
"author": {
|
||||
"id": 9542
|
||||
},
|
||||
"writtenOn": "2019-03-11T18:13:53Z",
|
||||
"side": 1,
|
||||
"message": "fwiw, I\u0027d add an ironic OOB just in case, so that any manipulation with the node are going thru ironic which should be the only authority and single source of truth.\n\nBut also I do need more info re why the need for separate OOB in the first place and whether we can skip it with ironic alltogether",
|
||||
"parentUuid": "9fdfeff1_790a007a",
|
||||
"range": {
|
||||
"startLine": 203,
|
||||
"startChar": 48,
|
||||
"endLine": 203,
|
||||
"endChar": 75
|
||||
},
|
||||
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_3a7ea1af",
|
||||
|
|
@ -578,6 +650,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_8b685721",
|
||||
"filename": "specs/approved/drydock_ironic_integration.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 285,
|
||||
"author": {
|
||||
"id": 9542
|
||||
},
|
||||
"writtenOn": "2019-03-11T18:13:53Z",
|
||||
"side": 1,
|
||||
"message": "yes, ironic does not so need to manage IP addresses, but DHCP options for PXE returned with DHCP response\n\nthis could be populated from the HW model which is fed to shipyard as it already contains MAC addresses if I\u0027m not mistaken.",
|
||||
"parentUuid": "9fdfeff1_d963ec40",
|
||||
"range": {
|
||||
"startLine": 283,
|
||||
"startChar": 51,
|
||||
"endLine": 285,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_dddd26de",
|
||||
|
|
@ -601,6 +697,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_8bd617c3",
|
||||
"filename": "specs/approved/drydock_ironic_integration.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 290,
|
||||
"author": {
|
||||
"id": 9542
|
||||
},
|
||||
"writtenOn": "2019-03-11T18:13:53Z",
|
||||
"side": 1,
|
||||
"message": "I would start with non-HA for MVP. To have HA one would either need a DHCP server with remotely configurable settings + a new ironic dhcp driver for it, or the dynamic iPXE config spec implemented in ironic.",
|
||||
"parentUuid": "9fdfeff1_dddd26de",
|
||||
"range": {
|
||||
"startLine": 290,
|
||||
"startChar": 3,
|
||||
"endLine": 290,
|
||||
"endChar": 10
|
||||
},
|
||||
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_d9c8cc22",
|
||||
|
|
@ -624,6 +744,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_cbedff8b",
|
||||
"filename": "specs/approved/drydock_ironic_integration.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 309,
|
||||
"author": {
|
||||
"id": 9542
|
||||
},
|
||||
"writtenOn": "2019-03-11T18:13:53Z",
|
||||
"side": 1,
|
||||
"message": "IMO this is one of possible pre-requisites for standalone ironic HA, the other one is remotely configurable DHCP server + ironic dhcp driver for it.\nThe former has an approved spec and an unmerged implementation that was working couple of releases ago, so presumably more realistic to get merged in Train release (too late for Stein already).",
|
||||
"parentUuid": "9fdfeff1_d9c8cc22",
|
||||
"range": {
|
||||
"startLine": 296,
|
||||
"startChar": 0,
|
||||
"endLine": 309,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "cbc5ca0deb1ac0d2b61557cc4012d50aa6079f20",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fdfeff1_bde06299",
|
||||
|
|
|
|||
Loading…
Reference in New Issue