167 lines
5.0 KiB
Plaintext
167 lines
5.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_08099032",
|
|
"filename": ".zuul.yaml",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 35,
|
|
"author": {
|
|
"id": 28618
|
|
},
|
|
"writtenOn": "2018-11-23T17:44:41Z",
|
|
"side": 1,
|
|
"message": "Why maintain duplicate copies of these playbooks and instead run them from the cloned OSH-infra repository?",
|
|
"range": {
|
|
"startLine": 35,
|
|
"startChar": 0,
|
|
"endLine": 35,
|
|
"endChar": 62
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_07f71d90",
|
|
"filename": ".zuul.yaml",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 35,
|
|
"author": {
|
|
"id": 21813
|
|
},
|
|
"writtenOn": "2018-11-26T23:50:59Z",
|
|
"side": 1,
|
|
"message": "It\u0027s based on Shipyard. I see DH uses the same approach.\nDo you have a good example of how osh-infra can be used?",
|
|
"parentUuid": "3f79a3b5_08099032",
|
|
"range": {
|
|
"startLine": 35,
|
|
"startChar": 0,
|
|
"endLine": 35,
|
|
"endChar": 62
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_632145a1",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 28618
|
|
},
|
|
"writtenOn": "2018-11-23T17:44:41Z",
|
|
"side": 1,
|
|
"message": "q: Are there any plans to configure this repository for multiple charts before more are added? From the looks of it right now, adding more charts will require moving a lot of directories and additional Makefile changes.\n\nA structure similar to the OpenStack-Helm repository could be used.",
|
|
"range": {
|
|
"startLine": 12,
|
|
"startChar": 0,
|
|
"endLine": 14,
|
|
"endChar": 60
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_c7c6054b",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 14,
|
|
"author": {
|
|
"id": 21813
|
|
},
|
|
"writtenOn": "2018-11-26T23:50:59Z",
|
|
"side": 1,
|
|
"message": "I thought about that question and have no idea about any plans. Probably sometime somewhere.\nAs we don\u0027t know what a new component of airship-utils (would it have a chart, Dockerfile and so on) it seems better to leave that decision until info is available.\nHowever, it makes sense to me now to move all mini-mirror related files to one folder. Will update.",
|
|
"parentUuid": "3f79a3b5_632145a1",
|
|
"range": {
|
|
"startLine": 12,
|
|
"startChar": 0,
|
|
"endLine": 14,
|
|
"endChar": 60
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_a8ef3c7e",
|
|
"filename": "tools/gate/playbooks/vars.yaml",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 28618
|
|
},
|
|
"writtenOn": "2018-11-23T17:44:41Z",
|
|
"side": 1,
|
|
"message": "Is this file required, or is it a placeholder?",
|
|
"range": {
|
|
"startLine": 1,
|
|
"startChar": 0,
|
|
"endLine": 15,
|
|
"endChar": 10
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_c8fcf841",
|
|
"filename": "tools/gate/playbooks/zuul-check.yaml",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 28618
|
|
},
|
|
"writtenOn": "2018-11-23T17:44:41Z",
|
|
"side": 1,
|
|
"message": "Instead of using:\n\n sudo\n\nuse:\n\n become: yes\n\n[0] https://docs.ansible.com/ansible/2.6/user_guide/become.html#id1",
|
|
"range": {
|
|
"startLine": 18,
|
|
"startChar": 15,
|
|
"endLine": 18,
|
|
"endChar": 19
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_88f28069",
|
|
"filename": "tools/gate/playbooks/zuul-linter.yaml",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 28618
|
|
},
|
|
"writtenOn": "2018-11-23T17:44:41Z",
|
|
"side": 1,
|
|
"message": "Instead of using:\n\n sudo\n\nuse:\n\n become: yes\n\n[0] https://docs.ansible.com/ansible/2.6/user_guide/become.html#id1",
|
|
"range": {
|
|
"startLine": 18,
|
|
"startChar": 15,
|
|
"endLine": 18,
|
|
"endChar": 19
|
|
},
|
|
"revId": "4584b7c7cd52ec649bedc38832abf1657070eab9",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |