From ca1a082f36cee075e7a02ad568d41c4f82e6e96d Mon Sep 17 00:00:00 2001 From: Gerrit User 22477 <22477@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 5 Dec 2018 19:08:32 +0000 Subject: [PATCH] Update patch set 5 Patch Set 5: Code-Review-1 (1 comment) Patch-set: 5 Reviewer: Gerrit User 22477 <22477@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 --- b1b4575eff95c1ad64d2ae1c2b23b5973410a953 | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 b1b4575eff95c1ad64d2ae1c2b23b5973410a953 diff --git a/b1b4575eff95c1ad64d2ae1c2b23b5973410a953 b/b1b4575eff95c1ad64d2ae1c2b23b5973410a953 new file mode 100644 index 0000000..4442046 --- /dev/null +++ b/b1b4575eff95c1ad64d2ae1c2b23b5973410a953 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "3f79a3b5_da7dba1d", + "filename": "mini-mirror/assets/startup.sh", + "patchSetId": 5 + }, + "lineNbr": 49, + "author": { + "id": 22477 + }, + "writtenOn": "2018-12-05T19:08:32Z", + "side": 1, + "message": "Wouln\u0027t it be more consistent and desirable to bind mount the key in (as above) rather than pulling from a URL at runtime every time nginx starts up? And for enterprise purposes, couldn\u0027t the key be simply be mounted as the ubuntu-archive-keyring.gpg above, so that no code change is needed?", + "revId": "b1b4575eff95c1ad64d2ae1c2b23b5973410a953", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file