From 2bb653147422d99fa6b629691f6527e8ab56227f Mon Sep 17 00:00:00 2001
From: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Fri, 23 Nov 2018 18:00:22 +0000
Subject: [PATCH] Update patch set 8

Patch Set 8: Code-Review-1

(8 comments)

Patch-set: 8
Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
---
 034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f | 182 +++++++++++++++++++++++
 1 file changed, 182 insertions(+)
 create mode 100644 034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f

diff --git a/034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f b/034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f
new file mode 100644
index 0000000..54a1b13
--- /dev/null
+++ b/034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f
@@ -0,0 +1,182 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3f79a3b5_23e82d12",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 8
+      },
+      "lineNbr": 11,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "This is part of a change sequence. Please add:\n\n Depends-On: https://review.openstack.org/613702\n Depends-On: https://review.openstack.org/614043",
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_e3d55549",
+        "filename": "Makefile",
+        "patchSetId": 8
+      },
+      "lineNbr": 56,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "I wouldn\u0027t necessarily expect a test target to install the Helm chart. What is the purpose of this target?",
+      "range": {
+        "startLine": 56,
+        "startChar": 1,
+        "endLine": 56,
+        "endChar": 57
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_a3dbdd78",
+        "filename": "charts/mini-mirror/requirements.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "nit: we do not include this character in any other repository header files.",
+      "range": {
+        "startLine": 2,
+        "startChar": 12,
+        "endLine": 2,
+        "endChar": 15
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_25227554",
+        "filename": "charts/mini-mirror/templates/deployment.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "nit: we do not include this character in any other repository header files.",
+      "range": {
+        "startLine": 2,
+        "startChar": 12,
+        "endLine": 2,
+        "endChar": 15
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_63cb85a6",
+        "filename": "charts/mini-mirror/templates/ingress.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "nit: we do not include this character in any other repository header files.",
+      "range": {
+        "startLine": 3,
+        "startChar": 10,
+        "endLine": 3,
+        "endChar": 13
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_23c10d84",
+        "filename": "charts/mini-mirror/templates/service.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "nit: we do not include this character in any other repository header files.",
+      "range": {
+        "startLine": 3,
+        "startChar": 10,
+        "endLine": 3,
+        "endChar": 13
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_e3431511",
+        "filename": "tools/gate/playbooks/zuul-check.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "Instead of using:\n\n sudo\n\nuse:\n\n become: yes\n\n[0] https://docs.ansible.com/ansible/2.6/user_guide/become.html#id1",
+      "range": {
+        "startLine": 18,
+        "startChar": 15,
+        "endLine": 18,
+        "endChar": 19
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_a3499d30",
+        "filename": "tools/gate/playbooks/zuul-check.yaml",
+        "patchSetId": 8
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2018-11-23T18:00:22Z",
+      "side": 1,
+      "message": "Is there a reason there is a Makefile target for this? We could perform the installation directly from the playbook.",
+      "range": {
+        "startLine": 18,
+        "startChar": 20,
+        "endLine": 18,
+        "endChar": 42
+      },
+      "revId": "034dae9e0f6a9e9e0c6bc581ca6d8e3ee1065b7f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}
\ No newline at end of file