139 lines
3.9 KiB
Plaintext
139 lines
3.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_ced3ea37",
|
|
"filename": "tox.ini",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 5689
|
|
},
|
|
"writtenOn": "2019-05-07T23:36:51Z",
|
|
"side": 1,
|
|
"message": "I\u0027m curious that there\u0027s no py37 here. But it\u0027s another topic.",
|
|
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_8e35f248",
|
|
"filename": "tox.ini",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 20466
|
|
},
|
|
"writtenOn": "2019-05-08T00:03:39Z",
|
|
"side": 1,
|
|
"message": "Airship was designed with py3 in mind, and py2 is EOL 2020, we should just remove py27",
|
|
"range": {
|
|
"startLine": 3,
|
|
"startChar": 20,
|
|
"endLine": 3,
|
|
"endChar": 25
|
|
},
|
|
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_48ae0999",
|
|
"filename": "tox.ini",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 29624
|
|
},
|
|
"writtenOn": "2019-05-08T12:58:38Z",
|
|
"side": 1,
|
|
"message": "suggest in a separate patch removing py27, and adding py37 as a check - but not a gate - to see if we are currently py37 compatible. if so, we can consider adding the gate as well to keep code future compatible.",
|
|
"range": {
|
|
"startLine": 3,
|
|
"startChar": 20,
|
|
"endLine": 3,
|
|
"endChar": 24
|
|
},
|
|
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_28b2b5e7",
|
|
"filename": "tox.ini",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 30106
|
|
},
|
|
"writtenOn": "2019-05-08T13:03:47Z",
|
|
"side": 1,
|
|
"message": "I\u0027d be happy to add py* here and remove py27, but I agree with the others that it should be a separate PS.",
|
|
"parentUuid": "dfbec78f_8e35f248",
|
|
"range": {
|
|
"startLine": 3,
|
|
"startChar": 20,
|
|
"endLine": 3,
|
|
"endChar": 25
|
|
},
|
|
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_48ea89ac",
|
|
"filename": "tox.ini",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 30106
|
|
},
|
|
"writtenOn": "2019-05-08T13:04:38Z",
|
|
"side": 1,
|
|
"message": "Also, just to be clear, by \"py*\" I meant \"whatever we decide makes most sense\". Not literally py*.",
|
|
"parentUuid": "dfbec78f_28b2b5e7",
|
|
"range": {
|
|
"startLine": 3,
|
|
"startChar": 20,
|
|
"endLine": 3,
|
|
"endChar": 25
|
|
},
|
|
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfbec78f_c204044d",
|
|
"filename": "tox.ini",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 30106
|
|
},
|
|
"writtenOn": "2019-05-09T13:50:26Z",
|
|
"side": 1,
|
|
"message": "I\u0027ve created a new change based off of this one to remove py27, https://review.opendev.org/#/c/658082/.",
|
|
"parentUuid": "dfbec78f_8e35f248",
|
|
"range": {
|
|
"startLine": 3,
|
|
"startChar": 20,
|
|
"endLine": 3,
|
|
"endChar": 25
|
|
},
|
|
"revId": "ce79550ee1fa12ea0d677b13a94c737c706f8541",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |