airship
/
tempest-plugin
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(4 comments)

Patch-set: 2
Label: Code-Review=-1
This commit is contained in:
Gerrit User 17896 2018-12-11 22:31:32 +00:00 committed by Gerrit Code Review
parent ed7a2d3ce7
commit bac240739e
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
312300d8bf5c3d02a5a2011767dbf4ca374134a3 Normal file
View File

@ -0,0 +1,96 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_3d0eb33c",
"filename": "airship_tempest_plugin/services/shipyard/json/airflow_monitoring_client.py",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 17896
},
"writtenOn": "2018-12-11T22:31:32Z",
"side": 1,
"message": "incorrect indent",
"range": {
"startLine": 33,
"startChar": 8,
"endLine": 33,
"endChar": 9
},
"revId": "312300d8bf5c3d02a5a2011767dbf4ca374134a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_bdf9631e",
"filename": "airship_tempest_plugin/services/shipyard/json/document_staging_client.py",
"patchSetId": 2
},
"lineNbr": 40,
"author": {
"id": 17896
},
"writtenOn": "2018-12-11T22:31:32Z",
"side": 1,
"message": "incorrect indent",
"range": {
"startLine": 40,
"startChar": 8,
"endLine": 40,
"endChar": 16
},
"revId": "312300d8bf5c3d02a5a2011767dbf4ca374134a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_68f46b25",
"filename": "airship_tempest_plugin/services/shipyard/json/document_staging_client.py",
"patchSetId": 2
},
"lineNbr": 58,
"author": {
"id": 17896
},
"writtenOn": "2018-12-11T22:31:32Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 58,
"startChar": 8,
"endLine": 58,
"endChar": 16
},
"revId": "312300d8bf5c3d02a5a2011767dbf4ca374134a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_88f9c71c",
"filename": "airship_tempest_plugin/services/shipyard/json/document_staging_client.py",
"patchSetId": 2
},
"lineNbr": 67,
"author": {
"id": 17896
},
"writtenOn": "2018-12-11T22:31:32Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 67,
"startChar": 8,
"endLine": 67,
"endChar": 16
},
"revId": "312300d8bf5c3d02a5a2011767dbf4ca374134a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}