Update patch set 4
Patch Set 4: Code-Review-1 (8 comments) Patch-set: 4 Reviewer: Gerrit User 23186 <23186@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
Gerrit User 23186
Gerrit Code Review
parent
2b6af4df4e
commit
8cdf75d89f
|
|
@ -0,0 +1,188 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_f0145552",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_actions.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "self.assertIn(\u0027command_audit\u0027, resp)\nself.assertIsNotNone(resp[\u0027command_audit\u0027])",
|
||||
"range": {
|
||||
"startLine": 51,
|
||||
"startChar": 8,
|
||||
"endLine": 51,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_101a317b",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_actions.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 55,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "Please remove.",
|
||||
"range": {
|
||||
"startLine": 53,
|
||||
"startChar": 0,
|
||||
"endLine": 55,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_565ae21e",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 61,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "This test should ensure that the right setup steps are performed so that this try/except is not needed. Relying on the existence of resources already existing is not a reliable integration test.",
|
||||
"range": {
|
||||
"startLine": 53,
|
||||
"startChar": 0,
|
||||
"endLine": 61,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_9664fae7",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "This test should ensure that the right setup steps are performed so that this try/except is not needed. Relying on the existence of resources already existing is not a reliable integration test.",
|
||||
"range": {
|
||||
"startLine": 70,
|
||||
"startChar": 0,
|
||||
"endLine": 78,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_d666f2f0",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 131,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "This test should ensure that the right setup steps are performed so that this try/except is not needed. Relying on the existence of resources already existing is not a reliable integration test.",
|
||||
"range": {
|
||||
"startLine": 123,
|
||||
"startChar": 0,
|
||||
"endLine": 131,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_367646a5",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 148,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "This test should ensure that the right setup steps are performed so that this try/except is not needed. Relying on the existence of resources already existing is not a reliable integration test.",
|
||||
"range": {
|
||||
"startLine": 140,
|
||||
"startChar": 0,
|
||||
"endLine": 148,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_5613c25a",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 166,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "Not true.",
|
||||
"range": {
|
||||
"startLine": 166,
|
||||
"startChar": 10,
|
||||
"endLine": 166,
|
||||
"endChar": 68
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_f6520e11",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 177,
|
||||
"author": {
|
||||
"id": 23186
|
||||
},
|
||||
"writtenOn": "2018-11-06T14:13:57Z",
|
||||
"side": 1,
|
||||
"message": "This test should ensure that the right setup steps are performed so that this try/except is not needed. Relying on the existence of resources already existing is not a reliable integration test.",
|
||||
"range": {
|
||||
"startLine": 169,
|
||||
"startChar": 0,
|
||||
"endLine": 177,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue