Update patch set 4
Patch Set 4: (6 comments) Patch-set: 4 Reviewer: Gerrit User 23363 <23363@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
Gerrit User 23363
Gerrit Code Review
parent
04bc04440a
commit
0c8bf6a45c
|
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_19b9fd7a",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_actions.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 23363
|
||||
},
|
||||
"writtenOn": "2018-11-06T15:07:14Z",
|
||||
"side": 1,
|
||||
"message": "Sure. we will incorporate this.",
|
||||
"parentUuid": "3f79a3b5_f0145552",
|
||||
"range": {
|
||||
"startLine": 51,
|
||||
"startChar": 8,
|
||||
"endLine": 51,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_101a317b",
|
||||
|
|
@ -69,6 +93,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_b9f1e998",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 61,
|
||||
"author": {
|
||||
"id": 23363
|
||||
},
|
||||
"writtenOn": "2018-11-06T15:07:14Z",
|
||||
"side": 1,
|
||||
"message": "Agreed, we will look into it, but am not sure if we can commit a collection using the APIs and also we are not sure about the CICD environment if that would be able to handle those operations, hence we did not do that. Please let me know if you dont see that as a challenge",
|
||||
"parentUuid": "3f79a3b5_565ae21e",
|
||||
"range": {
|
||||
"startLine": 53,
|
||||
"startChar": 0,
|
||||
"endLine": 61,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_9664fae7",
|
||||
|
|
@ -92,6 +140,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_d92b85e6",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 23363
|
||||
},
|
||||
"writtenOn": "2018-11-06T15:07:14Z",
|
||||
"side": 1,
|
||||
"message": "as per Shipyard API documentation, 404 is a valid scenario and we can expect it as a positive scenario if there are no collections/document available. So we might as well want to handle such scenario as well(maybe a separate testcase with SetupResource).",
|
||||
"parentUuid": "3f79a3b5_9664fae7",
|
||||
"range": {
|
||||
"startLine": 70,
|
||||
"startChar": 0,
|
||||
"endLine": 78,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_d666f2f0",
|
||||
|
|
@ -115,6 +187,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_99398d41",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 131,
|
||||
"author": {
|
||||
"id": 23363
|
||||
},
|
||||
"writtenOn": "2018-11-06T15:07:14Z",
|
||||
"side": 1,
|
||||
"message": "ditto as above",
|
||||
"parentUuid": "3f79a3b5_d666f2f0",
|
||||
"range": {
|
||||
"startLine": 123,
|
||||
"startChar": 0,
|
||||
"endLine": 131,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_367646a5",
|
||||
|
|
@ -161,6 +257,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_f99a0110",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 166,
|
||||
"author": {
|
||||
"id": 23363
|
||||
},
|
||||
"writtenOn": "2018-11-06T15:07:14Z",
|
||||
"side": 1,
|
||||
"message": "Transcript from API doc\n\n404 Not Found\nIf the collection is not represented\n\nWhen version\u003dbuffer, this indicates that no representations of this collection have been POSTed since the last committed version.\nWhen version\u003dcommitted, this indicates that either the collection has never existed or has been deleted by a prior commit.",
|
||||
"parentUuid": "3f79a3b5_5613c25a",
|
||||
"range": {
|
||||
"startLine": 166,
|
||||
"startChar": 10,
|
||||
"endLine": 166,
|
||||
"endChar": 68
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_f6520e11",
|
||||
|
|
@ -183,6 +303,30 @@
|
|||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_9983cdaa",
|
||||
"filename": "airship_tempest_plugin/tests/api/shipyard/test_document_staging.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 177,
|
||||
"author": {
|
||||
"id": 23363
|
||||
},
|
||||
"writtenOn": "2018-11-06T15:07:14Z",
|
||||
"side": 1,
|
||||
"message": "ditto",
|
||||
"parentUuid": "3f79a3b5_f6520e11",
|
||||
"range": {
|
||||
"startLine": 169,
|
||||
"startChar": 0,
|
||||
"endLine": 177,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "cd0711709629d951f69962a64ef1cac07fb7af34",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue