airship
/
specs
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(4 comments)

Patch-set: 7
Label: Code-Review=-1
This commit is contained in:
Gerrit User 28208 2019-07-05 15:22:04 +00:00 committed by Gerrit Code Review
parent 4cd7bec3a0
commit e6224f1224
1 changed files with 84 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
2aafaa80486da0deb8c1fd118b40f7b3e5a91982 Normal file
View File

@ -0,0 +1,84 @@
{
"comments": [
{
"key": {
"uuid": "7faddb67_d313c20c",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 7
},
"lineNbr": 32,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:22:04Z",
"side": 1,
"message": "Probably \"delays\", not \"errors\". But \"errors\" is still fine.",
"range": {
"startLine": 32,
"startChar": 71,
"endLine": 32,
"endChar": 77
},
"revId": "2aafaa80486da0deb8c1fd118b40f7b3e5a91982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_f3d27e34",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 7
},
"lineNbr": 45,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:22:04Z",
"side": 1,
"message": "Please, check how it conforms to https://airshipit.readthedocs.io/en/latest/service-logging-conventions.html , some changes might be needed.",
"revId": "2aafaa80486da0deb8c1fd118b40f7b3e5a91982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_73e68e19",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 7
},
"lineNbr": 127,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:22:04Z",
"side": 1,
"message": "Dot (.) is missing.",
"revId": "2aafaa80486da0deb8c1fd118b40f7b3e5a91982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_13c15a55",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 7
},
"lineNbr": 156,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:22:04Z",
"side": 1,
"message": "Update Armada documentation, listing log format, and use case with CRD/Prometheus; update https://airshipit.readthedocs.io/en/latest/service-logging-conventions.html if it would be needed.",
"range": {
"startLine": 156,
"startChar": 0,
"endLine": 156,
"endChar": 4
},
"revId": "2aafaa80486da0deb8c1fd118b40f7b3e5a91982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}