airship
/
specs
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review-1

(16 comments)

Patch-set: 9
Reviewer: Gerrit User 8749 <8749@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 8749 2019-05-21 18:44:06 +00:00 committed by Gerrit Code Review
parent 7df0a01620
commit cdbf33b2d7
1 changed files with 366 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

366
b2c481d0cc2695d85dad81b9444021f47f09c4d4 Normal file
View File

@ -0,0 +1,366 @@
{
"comments": [
{
"key": {
"uuid": "bfb3d3c7_ca1d1f74",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 46,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "nit: here and many other lines, should be consistently wrapped to make it readable on gerrit with default settings.",
"range": {
"startLine": 46,
"startChar": 79,
"endLine": 46,
"endChar": 80
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_2a25dbc2",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 74,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "Are there any specific ideas on implementing this? Should it be a single binary which is being extended during the compilation, or should it be more like a pluggable mechanism in kubectl [1]?\n\n[1] https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/",
"range": {
"startLine": 74,
"startChar": 0,
"endLine": 74,
"endChar": 9
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_65cc64bc",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 183,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "Should we prefix all plugin specific configs to reduce ambiguity? E.g. with set-document-repository, set-document-clone-path, etc.",
"range": {
"startLine": 183,
"startChar": 25,
"endLine": 183,
"endChar": 29
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a59b3cc7",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 192,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "nit: pegleg documentation refers to this file as \"site-definition.yaml\"",
"range": {
"startLine": 192,
"startChar": 76,
"endLine": 192,
"endChar": 96
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_e5f054cc",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 212,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "Is this one-time command? Or is it idempotent and would allow me to run it as many times as I want? Should we implement erase-bootstrap to be able to bootstrap the cluster from scratch?",
"range": {
"startLine": 212,
"startChar": 14,
"endLine": 212,
"endChar": 23
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a5bc9cdc",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 237,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "nit: here and below are many trailing spaces.",
"range": {
"startLine": 237,
"startChar": 70,
"endLine": 237,
"endChar": 71
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a58a5c18",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 275,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "deployed",
"range": {
"startLine": 275,
"startChar": 48,
"endLine": 275,
"endChar": 57
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_6584640d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 275,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "CRDs",
"range": {
"startLine": 275,
"startChar": 95,
"endLine": 275,
"endChar": 98
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_0573284f",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 288,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "bundle?",
"range": {
"startLine": 288,
"startChar": 51,
"endLine": 288,
"endChar": 57
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_65b224e9",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 317,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "++",
"range": {
"startLine": 317,
"startChar": 111,
"endLine": 317,
"endChar": 138
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_05d6c8f2",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 323,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "Should probably run all types of validation by default, if no options specified.",
"range": {
"startLine": 323,
"startChar": 2,
"endLine": 323,
"endChar": 18
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_45512062",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 335,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "Looking at site authoring guide in treasuremap, creating a deployable reference document would require a lot of manual work from the user, this makes creating a skeleton of the Airship documents a negligible problem (considering they can be easily copied from an existing repo). Is it worth implementing it as this stage?",
"range": {
"startLine": 335,
"startChar": 28,
"endLine": 335,
"endChar": 32
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_05e00896",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 390,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "I have the same question as for \"bootstrap\" is this command re-runnable, does it participate life cycle management of the site?",
"range": {
"startLine": 390,
"startChar": 2,
"endLine": 390,
"endChar": 6
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_25dbcced",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 400,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "++",
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_05f9e84b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 413,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "Is this a warpper on top of Argo? Or is it only for managing the YAMLs and not for interacting with Argo?",
"range": {
"startLine": 413,
"startChar": 17,
"endLine": 413,
"endChar": 25
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_85a2b84a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 433,
"author": {
"id": 8749
},
"writtenOn": "2019-05-21T18:44:06Z",
"side": 1,
"message": "doesn\u0027t",
"range": {
"startLine": 433,
"startChar": 45,
"endLine": 433,
"endChar": 51
},
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}