Update patch set 9

Patch Set 9:

(5 comments)

Patch-set: 9
Reviewer: Gerrit User 7769 <7769@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 7769 2019-05-21 23:39:16 +00:00 committed by Gerrit Code Review
parent d52656152f
commit a6936423e2
1 changed files with 85 additions and 0 deletions

View File

@ -115,6 +115,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_ab38ea3c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 218,
"author": {
"id": 7769
},
"writtenOn": "2019-05-21T23:39:16Z",
"side": 1,
"message": "Clearly this definition will evolve, but:\n\n- optional [phase] to target just one phase in the bootstrap process\n- determine whether bootstrap should try and orchestrate something like k3s itself or expect the user to have done that prior to bootstrap. Cost of embedding k3s (50MB) is really the k8s images (200MB). The installation outside of airship is rather simple: \n-- sudo k3s server \u0026\n-- # Kubeconfig is written to /etc/rancher/k3s/k3s.yaml\n-- sudo k3s kubectl get node\n- if we expect a pre-existing cluster, ephemeral or not, they will need to provide kubeconfig context for the ephemeral cluster cluster which may be separate from what is defined for the site\n- if this is effectively driving what clusterctl would do, presumably the yaml it needs is within the overall document set and we can find them (e.g. provider components, machines)\n- how will we know we need to insert things like baremetalnodes, as that is provider dependant, e.g. required for metal3-io but not for azure.",
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a5bc9cdc",
@ -138,6 +155,40 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_0b49f6ce",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 258,
"author": {
"id": 7769
},
"writtenOn": "2019-05-21T23:39:16Z",
"side": 1,
"message": "is this equivalent to pegleg collect?",
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_eb17c2a2",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 273,
"author": {
"id": 7769
},
"writtenOn": "2019-05-21T23:39:16Z",
"side": 1,
"message": "I think we should consider making Armada documents simply proper CRDs so that there are only CRDs - even if we dont leverage an armada operator. Need to factor in how we can securely store them though like secrets, as they may contain passwords after bundling.",
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a58a5c18",
@ -207,6 +258,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_ab11caae",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 290,
"author": {
"id": 7769
},
"writtenOn": "2019-05-21T23:39:16Z",
"side": 1,
"message": "What is the difference create and apply?",
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_65b224e9",
@ -276,6 +344,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_cbc75e12",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 9
},
"lineNbr": 341,
"author": {
"id": 7769
},
"writtenOn": "2019-05-21T23:39:16Z",
"side": 1,
"message": "We may want to pay careful attention to the directory layout especially for bootstrapping, because it may be one of the ways we can signal to the bootstrap process what documents should be fed in during a clusterctl like process. In other words, what are the add-ons, what are the provider components, and so on - normally these are fed directly in as yaml snippets to the application where we need to find them in the larger airship document payload",
"revId": "b2c481d0cc2695d85dad81b9444021f47f09c4d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_05e00896",