Update patch set 22
Patch Set 22: Code-Review-1 (2 comments) Looks good to me, just a couple additional thoughts before we merge. Patch-set: 22 Label: Code-Review=-1
This commit is contained in:
parent
0b8f7b4dba
commit
a52eba014e
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fa7e38b_93ebcada",
|
||||
"filename": "specs/2.x/approved/airshipctl_bootstrap_isogen.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 136,
|
||||
"author": {
|
||||
"id": 22477
|
||||
},
|
||||
"writtenOn": "2019-10-07T22:21:50Z",
|
||||
"side": 1,
|
||||
"message": "Can we please clarify this a bit -- it\u0027s not 100% clear (to me at least) what \"actual file name\" refers to in this context.",
|
||||
"range": {
|
||||
"startLine": 136,
|
||||
"startChar": 2,
|
||||
"endLine": 136,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "46b64c09c9ddd381a219effce5a1c7f2f0d33c52",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fa7e38b_d345c216",
|
||||
"filename": "specs/2.x/approved/airshipctl_bootstrap_isogen.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 144,
|
||||
"author": {
|
||||
"id": 22477
|
||||
},
|
||||
"writtenOn": "2019-10-07T22:21:50Z",
|
||||
"side": 1,
|
||||
"message": "Can we standardize on either snake_case or camelCase? Or, is there a reason to use both here (e.g. this file is consumed by an existing tool)? boot_image_path is used here, and e.g. userDataFileName is used below.\n\nI\u0027ve also added an item to the SIG-YAML agenda to discuss whether it makes sense to standardize across all Airship 2.0 docs.",
|
||||
"revId": "46b64c09c9ddd381a219effce5a1c7f2f0d33c52",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue