airship
/
specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(12 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 23186 2018-07-17 17:20:55 +00:00 committed by Gerrit Code Review
parent 93612769ca
commit 9a6ac8fedc
1 changed files with 262 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

262
b1024c5366dc0eab39d859e2f1162d374e9d0575 Normal file
View File

@ -0,0 +1,262 @@
{
"comments": [
{
"key": {
"uuid": "5f7c97a3_9c7656d5",
"filename": ".gitignore",
"patchSetId": 2
},
"lineNbr": 6,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "WS",
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_dc704edd",
"filename": "Makefile",
"patchSetId": 2
},
"lineNbr": 6,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "There are some additional flags that are worth enabling: https://github.com/openstack/airship-deckhand/blob/0ac33c233d59a731bf289db23ec4a882ff359168/tox.ini#L130",
"range": {
"startLine": 6,
"startChar": 16,
"endLine": 6,
"endChar": 28
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_7c79fac3",
"filename": "doc/source/index.rst",
"patchSetId": 2
},
"lineNbr": 6,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "Should captitalize",
"range": {
"startLine": 6,
"startChar": 11,
"endLine": 6,
"endChar": 24
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1c448672",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 8,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "This should be its own patchset and in fact will expedite merge if this is layered as a child patch on top of this foundational airship-specs patch.",
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_9cfdf60a",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 13,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "These could all be links/references but is not very important",
"range": {
"startLine": 13,
"startChar": 12,
"endLine": 13,
"endChar": 19
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1f5558f9",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 27,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "is through a manual process",
"range": {
"startLine": 27,
"startChar": 45,
"endLine": 27,
"endChar": 62
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_df3a80c2",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 28,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "deployed site?",
"range": {
"startLine": 28,
"startChar": 44,
"endLine": 28,
"endChar": 48
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1f6eb8c7",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 45,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "You mention Deckhand above but it\u0027s not listed as an impacted component.",
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_9f59682a",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 52,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "This is where a reference is handy",
"range": {
"startLine": 51,
"startChar": 57,
"endLine": 52,
"endChar": 11
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_df6360dc",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 54,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "of the",
"range": {
"startLine": 54,
"startChar": 34,
"endLine": 54,
"endChar": 37
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_9fae48e2",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 102,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "Perhaps add example labels here?",
"range": {
"startLine": 102,
"startChar": 25,
"endLine": 102,
"endChar": 27
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_5febd010",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 2
},
"lineNbr": 158,
"author": {
"id": 23186
},
"writtenOn": "2018-07-17T17:20:55Z",
"side": 1,
"message": "This seems out of place, what is a targeted action, does it need to be mentioned here?",
"range": {
"startLine": 151,
"startChar": 0,
"endLine": 158,
"endChar": 11
},
"revId": "b1024c5366dc0eab39d859e2f1162d374e9d0575",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}