airship
/
specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 18180 <18180@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=0
This commit is contained in:
Gerrit User 18180 2018-07-25 16:06:52 +00:00 committed by Gerrit Code Review
parent 08158717d1
commit 94c7096454
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
8c449495ba6a241c6dae501a90295455afe7fa77
View File

@ -70,6 +70,42 @@
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1ad7eb24",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 18180
},
"writtenOn": "2018-07-25T16:06:52Z",
"side": 1,
"message": "So approved as in you got your +2s and merged? Then once it\u0027s \"approved\" we have to immediately move it to the approved dir, requiring more +2s and merging?\nOr does \"approved\" mean something different?",
"parentUuid": "5f7c97a3_ba111753",
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_fa16aff3",
"filename": "specs/update_labels_workflow.rst",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 18180
},
"writtenOn": "2018-07-25T16:06:52Z",
"side": 1,
"message": "I would think having the impacted component would be part of it, where \"airship\" is a valid target. Or maybe the filename could just mention kubernetes to be more specific? \u0027airship_kubernetes_labels\u0027 or something?",
"parentUuid": "5f7c97a3_3a06671d",
"revId": "8c449495ba6a241c6dae501a90295455afe7fa77",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}