Update patch set 12

Patch Set 12:

(5 comments)

Patch-set: 12
Reviewer: Gerrit User 22477 <22477@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0

1080aecf3f6f1232b074aee91d9530a334f906d3

@@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9fb8cfa7_49196177",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 34,
+      "author": {
+        "id": 22477
+      },
+      "writtenOn": "2019-06-03T23:31:38Z",
+      "side": 1,
+      "message": "Asterisks are getting rendered as asterisks instead of italics.  I think we just need asterisks or backticks.",
+      "range": {
+        "startLine": 34,
+        "startChar": 19,
+        "endLine": 34,
+        "endChar": 20
+      },
+      "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fb8cfa7_498e4179",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 118,
+      "author": {
+        "id": 22477
+      },
+      "writtenOn": "2019-06-03T23:31:38Z",
+      "side": 1,
+      "message": "Will config handling (both the airship-specific stuff and the stuff that gets delegated to kubectl client/cli) be handled by a plugin, or by the cli project itself?  Might be a good thing to call out explicitly.",
+      "range": {
+        "startLine": 118,
+        "startChar": 0,
+        "endLine": 118,
+        "endChar": 6
+      },
+      "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fb8cfa7_893d19bd",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 127,
+      "author": {
+        "id": 22477
+      },
+      "writtenOn": "2019-06-03T23:31:38Z",
+      "side": 1,
+      "message": "I think we can get rid of the asterisks in all the examples",
+      "range": {
+        "startLine": 127,
+        "startChar": 2,
+        "endLine": 127,
+        "endChar": 3
+      },
+      "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fb8cfa7_69aea5e8",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 136,
+      "author": {
+        "id": 22477
+      },
+      "writtenOn": "2019-06-03T23:31:38Z",
+      "side": 1,
+      "message": "These backticks are rendering as a single long dash; to avoid confusion maybe we should put these in backticks (which will preserve --) or otherwise escape them",
+      "range": {
+        "startLine": 136,
+        "startChar": 5,
+        "endLine": 136,
+        "endChar": 7
+      },
+      "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9fb8cfa7_e9837555",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 161,
+      "author": {
+        "id": 22477
+      },
+      "writtenOn": "2019-06-03T23:31:38Z",
+      "side": 1,
+      "message": "These are also rendering as a single long dash",
+      "range": {
+        "startLine": 161,
+        "startChar": 67,
+        "endLine": 161,
+        "endChar": 69
+      },
+      "revId": "1080aecf3f6f1232b074aee91d9530a334f906d3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}