Update patch set 5
Patch Set 5: Code-Review-1 (3 comments) Patch-set: 5
This commit is contained in:
parent
1a690e0242
commit
80f8441e3d
|
@ -1,5 +1,74 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_43ad4199",
|
||||
"filename": "specs/approved/airship_multi_linux_distros.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-03-13T21:53:42Z",
|
||||
"side": 1,
|
||||
"message": "I think my comments were lost on a previous PS for this, but why not exclude the version numbers? Since we can override the FROM variable, the exact same Dockerfile.Ubuntu should work with Ubuntu Xenial and Ubuntu Bionic.",
|
||||
"range": {
|
||||
"startLine": 70,
|
||||
"startChar": 0,
|
||||
"endLine": 73,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "0259d21452987b11bb3f774c43d41fab86ef0720",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_238115fc",
|
||||
"filename": "specs/approved/airship_multi_linux_distros.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-03-13T21:53:42Z",
|
||||
"side": 1,
|
||||
"message": "Should we also mandate that Ubuntu includes it, even if it is default? Just for consistency and transparency (otherwise, looking at the Quay website, you cannot be sure which distro was used).",
|
||||
"range": {
|
||||
"startLine": 77,
|
||||
"startChar": 2,
|
||||
"endLine": 78,
|
||||
"endChar": 11
|
||||
},
|
||||
"revId": "0259d21452987b11bb3f774c43d41fab86ef0720",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_2396f53f",
|
||||
"filename": "specs/approved/airship_multi_linux_distros.rst",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2019-03-13T21:53:42Z",
|
||||
"side": 1,
|
||||
"message": "My version comment applies here as well.",
|
||||
"range": {
|
||||
"startLine": 79,
|
||||
"startChar": 2,
|
||||
"endLine": 81,
|
||||
"endChar": 31
|
||||
},
|
||||
"revId": "0259d21452987b11bb3f774c43d41fab86ef0720",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_0a68aeb6",
|
||||
|
|
Loading…
Reference in New Issue