Update patch set 7

Patch Set 7: Code-Review-1

(33 comments)

Super excited to see actual documentation describing what this tool will do - this will obviously be a very helpful resource while building airshipctl

Patch-set: 7
Label: Code-Review=-1
This commit is contained in:
Gerrit User 28869 2019-05-21 14:42:18 +00:00 committed by Gerrit Code Review
parent 2797ef7d64
commit 79eb6fce2d
1 changed files with 763 additions and 0 deletions

View File

@ -0,0 +1,763 @@
{
"comments": [
{
"key": {
"uuid": "bfb3d3c7_336f9a93",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 41,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "*airshipctl*",
"range": {
"startLine": 41,
"startChar": 4,
"endLine": 41,
"endChar": 14
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d302beb4",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 45,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "#airshipctl#",
"range": {
"startLine": 45,
"startChar": 6,
"endLine": 45,
"endChar": 16
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b3314aa5",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 46,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "#airshipctl#, which",
"range": {
"startLine": 46,
"startChar": 55,
"endLine": 46,
"endChar": 74
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_f3c0222d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 72,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "extra space",
"range": {
"startLine": 72,
"startChar": 40,
"endLine": 72,
"endChar": 42
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_53000e68",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 85,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "Guidelines",
"range": {
"startLine": 85,
"startChar": 3,
"endLine": 85,
"endChar": 12
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b3e06ace",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 86,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "trailing space",
"range": {
"startLine": 86,
"startChar": 87,
"endLine": 86,
"endChar": 88
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_333a3a34",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 113,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "*airshipctl*",
"range": {
"startLine": 113,
"startChar": 0,
"endLine": 113,
"endChar": 10
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_3368fa1f",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 129,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "We should consider using the XDG Directory standard for configuration files: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html",
"range": {
"startLine": 129,
"startChar": 11,
"endLine": 129,
"endChar": 38
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_3351da63",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 141,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "This is unclear",
"range": {
"startLine": 140,
"startChar": 105,
"endLine": 141,
"endChar": 108
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_f3dfc2d3",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 202,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 202,
"startChar": 92,
"endLine": 202,
"endChar": 96
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b3f38a73",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 204,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "Bootstrap",
"range": {
"startLine": 204,
"startChar": 0,
"endLine": 204,
"endChar": 8
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_53ea4e75",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 208,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "bootstrap",
"range": {
"startLine": 208,
"startChar": 14,
"endLine": 208,
"endChar": 22
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_33ff9a35",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 212,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 212,
"startChar": 10,
"endLine": 212,
"endChar": 14
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_939526e7",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 234,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "side, including",
"range": {
"startLine": 233,
"startChar": 65,
"endLine": 234,
"endChar": 9
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_539fae02",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 257,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 257,
"startChar": 35,
"endLine": 257,
"endChar": 39
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_73a2f24d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 259,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 259,
"startChar": 41,
"endLine": 259,
"endChar": 45
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_f38d82d3",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 267,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "documents",
"range": {
"startLine": 267,
"startChar": 33,
"endLine": 267,
"endChar": 41
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_53b80e75",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 267,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "CRDs",
"range": {
"startLine": 267,
"startChar": 112,
"endLine": 267,
"endChar": 117
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d392bef6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 268,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "extra space",
"range": {
"startLine": 268,
"startChar": 12,
"endLine": 268,
"endChar": 13
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_73bbd271",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 268,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "CRDs",
"range": {
"startLine": 268,
"startChar": 47,
"endLine": 268,
"endChar": 52
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_33ad5a31",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 268,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "extra space",
"range": {
"startLine": 268,
"startChar": 106,
"endLine": 268,
"endChar": 107
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_13605601",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 293,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "a",
"range": {
"startLine": 293,
"startChar": 56,
"endLine": 293,
"endChar": 59
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d3807e8e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 293,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "secrets",
"range": {
"startLine": 293,
"startChar": 45,
"endLine": 293,
"endChar": 51
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_96ff5400",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 423,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "triggered",
"range": {
"startLine": 423,
"startChar": 53,
"endLine": 423,
"endChar": 60
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d61cec6b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 424,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": ". E",
"range": {
"startLine": 424,
"startChar": 44,
"endLine": 424,
"endChar": 48
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_1613645e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 424,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 424,
"startChar": 30,
"endLine": 424,
"endChar": 34
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b62b7880",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 427,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "extra space",
"range": {
"startLine": 427,
"startChar": 10,
"endLine": 427,
"endChar": 11
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_967674a4",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 458,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "misaligned",
"range": {
"startLine": 458,
"startChar": 83,
"endLine": 458,
"endChar": 84
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_567ebc6b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 461,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "This is unclear. Do we mean predefined as in the \"sitemanage\" and \"redeployhost\" workflows? or do we mean predefined as in \"defined prior to running airshipctl\"?",
"range": {
"startLine": 461,
"startChar": 61,
"endLine": 461,
"endChar": 71
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_163cc4c6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 461,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 461,
"startChar": 50,
"endLine": 461,
"endChar": 54
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d6638cdb",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 462,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "YAML",
"range": {
"startLine": 462,
"startChar": 56,
"endLine": 462,
"endChar": 60
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_166a84b2",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 463,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "first",
"range": {
"startLine": 463,
"startChar": 5,
"endLine": 463,
"endChar": 8
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d6914c9b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 7
},
"lineNbr": 480,
"author": {
"id": 28869
},
"writtenOn": "2019-05-21T14:42:18Z",
"side": 1,
"message": "simply",
"range": {
"startLine": 480,
"startChar": 16,
"endLine": 480,
"endChar": 22
},
"revId": "d4135083ba5daf9e8911f526af467c465c91301e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}