Update patch set 3

Patch Set 3: Code-Review-1 (7 comments) I understand that this is an WIP patch, but looked into it anyways. Patch-set: 3 Label: Code-Review=-1
2019-05-17 21:25:17 +00:00 · 2019-05-17 21:25:17 +00:00 · 6d5bd4d7f8
parent 5660cd0928
commit 6d5bd4d7f8
1 changed files with 165 additions and 0 deletions
--- a/165
+++ b/165
@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "bfb3d3c7_69bc7369",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 28,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "nit: extra space",
+      "range": {
+        "startLine": 28,
+        "startChar": 35,
+        "endLine": 28,
+        "endChar": 36
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_a9c26be8",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 34,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "big",
+      "range": {
+        "startLine": 34,
+        "startChar": 2,
+        "endLine": 34,
+        "endChar": 6
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_097617da",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 42,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "What is \"CTL CLI\"? Does it refer to existing command line tools?",
+      "range": {
+        "startLine": 42,
+        "startChar": 61,
+        "endLine": 42,
+        "endChar": 68
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_a91eeb6d",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 87,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "nit: extra space",
+      "range": {
+        "startLine": 87,
+        "startChar": 42,
+        "endLine": 87,
+        "endChar": 43
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_b4887e71",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 180,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "nit: space after comma",
+      "range": {
+        "startLine": 180,
+        "startChar": 28,
+        "endLine": 180,
+        "endChar": 29
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_5427c265",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 186,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "Could you please elaborate on this?",
+      "range": {
+        "startLine": 186,
+        "startChar": 40,
+        "endLine": 186,
+        "endChar": 73
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_8f8e8725",
+        "filename": "specs/approved/airshipctl.rst",
+        "patchSetId": 3
+      },
+      "lineNbr": 282,
+      "author": {
+        "id": 8749
+      },
+      "writtenOn": "2019-05-17T21:25:17Z",
+      "side": 1,
+      "message": "Looks like a duplication of the message on line 226",
+      "range": {
+        "startLine": 280,
+        "startChar": 0,
+        "endLine": 282,
+        "endChar": 76
+      },
+      "revId": "66e012f8d52e30ce63d17014a2f8ddec0aa43290",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}