From 4bc6163c077e3e3f49e740fce923fea50353e28c Mon Sep 17 00:00:00 2001 From: Gerrit User 28208 <28208@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 11 Sep 2019 14:50:59 +0000 Subject: [PATCH] Update patch set 21 Patch Set 21: (6 comments) Could we separate a section for Airship 2.0 specs, please? In index file. Patch-set: 21 Reviewer: Gerrit User 28208 <28208@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0 --- e0453343e60fe4edfde6a3d543bf6aa67aea2b1f | 120 +++++++++++++++++++++++ 1 file changed, 120 insertions(+) diff --git a/e0453343e60fe4edfde6a3d543bf6aa67aea2b1f b/e0453343e60fe4edfde6a3d543bf6aa67aea2b1f index baaba54..259eaf5 100644 --- a/e0453343e60fe4edfde6a3d543bf6aa67aea2b1f +++ b/e0453343e60fe4edfde6a3d543bf6aa67aea2b1f @@ -1,5 +1,45 @@ { "comments": [ + { + "key": { + "uuid": "5faad753_13b913cb", + "filename": "specs/approved/airshipctl_bootstrap_image.rst", + "patchSetId": 21 + }, + "lineNbr": 13, + "author": { + "id": 28208 + }, + "writtenOn": "2019-09-11T14:50:59Z", + "side": 1, + "message": "single: ephemeral host", + "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "5faad753_f0cf8dad", + "filename": "specs/approved/airshipctl_bootstrap_image.rst", + "patchSetId": 21 + }, + "lineNbr": 77, + "author": { + "id": 28208 + }, + "writtenOn": "2019-09-11T14:50:59Z", + "side": 1, + "message": "airchip :)", + "range": { + "startLine": 77, + "startChar": 44, + "endLine": 77, + "endChar": 51 + }, + "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5faad753_86770403", @@ -23,6 +63,52 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5faad753_10902943", + "filename": "specs/approved/airshipctl_bootstrap_image.rst", + "patchSetId": 21 + }, + "lineNbr": 88, + "author": { + "id": 28208 + }, + "writtenOn": "2019-09-11T14:50:59Z", + "side": 1, + "message": "Remove. Sourced from airshipctl config (only current context (site/cluseter) is used when running this command, and only for ephemeral host).", + "range": { + "startLine": 84, + "startChar": 0, + "endLine": 88, + "endChar": 52 + }, + "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "5faad753_d08371cb", + "filename": "specs/approved/airshipctl_bootstrap_image.rst", + "patchSetId": 21 + }, + "lineNbr": 102, + "author": { + "id": 28208 + }, + "writtenOn": "2019-09-11T14:50:59Z", + "side": 1, + "message": "-", + "range": { + "startLine": 102, + "startChar": 65, + "endLine": 102, + "endChar": 66 + }, + "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5faad753_66668854", @@ -46,6 +132,23 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5faad753_f3aeb796", + "filename": "specs/approved/airshipctl_bootstrap_image.rst", + "patchSetId": 21 + }, + "lineNbr": 119, + "author": { + "id": 28208 + }, + "writtenOn": "2019-09-11T14:50:59Z", + "side": 1, + "message": "Kubernetes certificates are generated upfront.", + "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5faad753_e6511864", @@ -91,6 +194,23 @@ "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false + }, + { + "key": { + "uuid": "5faad753_b36fdf90", + "filename": "specs/approved/airshipctl_bootstrap_image.rst", + "patchSetId": 21 + }, + "lineNbr": 280, + "author": { + "id": 28208 + }, + "writtenOn": "2019-09-11T14:50:59Z", + "side": 1, + "message": "Clound-init contains sensitive information (e.g. could contain ssh keys).", + "revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false } ] } \ No newline at end of file