airship
/
specs
Code Issues Proposed changes

Update patch set 11 

Patch Set 11: Code-Review-1

(8 comments)

Patch-set: 11
Reviewer: Gerrit User 30173 <30173@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 30173 2019-05-28 15:04:42 +00:00 committed by Gerrit Code Review
parent d9269c85f4
commit 47f60c83a8
1 changed files with 169 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

169
f994baa982613b248e425f1564ed5956c6179cc4
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "bfb3d3c7_80c47ff6",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "nit: I\u0027d suggest capping the line length at 79 still so it\u0027s easier to read during review",
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_b81a6614",
@ -17,6 +34,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_c0f7d758",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 9,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "I think we could just say \"Resilience\" too",
"parentUuid": "9fdfeff1_b81a6614",
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_f8e54e0b",
@ -103,6 +138,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a02bc392",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 14,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "I agree with these edits or suggest \"The report and logging module helps ease the triage design issues.\"",
"parentUuid": "9fdfeff1_7805de79",
"range": {
"startLine": 14,
"startChar": 67,
"endLine": 14,
"endChar": 73
},
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_d8edeab7",
@ -149,6 +208,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_663ac4cc",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 19,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "isn\u0027t it just Airship?",
"parentUuid": "9fdfeff1_d8edeab7",
"range": {
"startLine": 19,
"startChar": 16,
"endLine": 19,
"endChar": 26
},
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_1839323e",
@ -361,6 +444,52 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_e67c7484",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 27,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "Remove",
"range": {
"startLine": 27,
"startChar": 4,
"endLine": 27,
"endChar": 12
},
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_666884b8",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 27,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "*?",
"range": {
"startLine": 27,
"startChar": 83,
"endLine": 27,
"endChar": 84
},
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_f8546e56",
@ -907,6 +1036,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_66964496",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 65,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "Perhaps \"Gives users granular control\"",
"range": {
"startLine": 65,
"startChar": 36,
"endLine": 65,
"endChar": 62
},
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_5ba7b40c",
@ -1331,6 +1483,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_c6d3705f",
"filename": "specs/approved/torpedo.rst",
"patchSetId": 11
},
"lineNbr": 138,
"author": {
"id": 30173
},
"writtenOn": "2019-05-28T15:04:42Z",
"side": 1,
"message": "Seems like this section could use bullet points",
"revId": "f994baa982613b248e425f1564ed5956c6179cc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_bb2d80a9",