airship
/
specs
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(6 comments)

Patch-set: 13
This commit is contained in:
Gerrit User 22259 2019-06-25 02:06:30 +00:00 committed by Gerrit Code Review
parent dfad7b5ced
commit 44ea6e17e7
1 changed files with 138 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

138
0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a
View File

@ -23,6 +23,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3d4967b6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 130,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "this should be `set-context`.",
"range": {
"startLine": 130,
"startChar": 20,
"endLine": 130,
"endChar": 39
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_73d91020",
@ -85,6 +108,121 @@
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_bd15574b",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 171,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "is there a special need for this command? we should be able to set the current context using `set-context my-context`",
"range": {
"startLine": 171,
"startChar": 25,
"endLine": 171,
"endChar": 42
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_6baf19e3",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 249,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "can remove this",
"range": {
"startLine": 249,
"startChar": 26,
"endLine": 249,
"endChar": 33
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_264cf8c6",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 277,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 277,
"startChar": 10,
"endLine": 277,
"endChar": 16
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_268f18ce",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 297,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 297,
"startChar": 51,
"endLine": 297,
"endChar": 56
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c6a07c45",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 297,
"author": {
"id": 22259
},
"writtenOn": "2019-06-25T02:06:30Z",
"side": 1,
"message": "typo",
"range": {
"startLine": 297,
"startChar": 23,
"endLine": 297,
"endChar": 30
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}