airship
/
specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(5 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 22604 2019-05-09 05:16:01 +00:00 committed by Gerrit Code Review
parent 2c0b26bd6e
commit 3d6f28b02a
1 changed files with 120 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

120
2ef874290fc7a0ca16cdff7c65d2844b0abee6b9
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_ba1d9d74",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 2
},
"lineNbr": 23,
"author": {
"id": 22604
},
"writtenOn": "2019-05-09T05:16:01Z",
"side": 1,
"message": "Done",
"parentUuid": "dfbec78f_515a4cf3",
"range": {
"startLine": 23,
"startChar": 50,
"endLine": 23,
"endChar": 53
},
"revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_4d1957d5",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_4dbb6e71",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 2
},
"lineNbr": 39,
"author": {
"id": 22604
},
"writtenOn": "2019-05-09T05:16:01Z",
"side": 1,
"message": "Added some answers, need to flesh it out more and look into the data capture requirements/locations",
"parentUuid": "dfbec78f_4d1957d5",
"range": {
"startLine": 37,
"startChar": 0,
"endLine": 39,
"endChar": 48
},
"revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_8dc66f67",
@ -69,6 +117,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_5a14a14e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 2
},
"lineNbr": 56,
"author": {
"id": 22604
},
"writtenOn": "2019-05-09T05:16:01Z",
"side": 1,
"message": "Done",
"parentUuid": "dfbec78f_8dc66f67",
"range": {
"startLine": 56,
"startChar": 30,
"endLine": 56,
"endChar": 31
},
"revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_2d62e33f",
@ -92,6 +164,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_8dc166e7",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 2
},
"lineNbr": 73,
"author": {
"id": 22604
},
"writtenOn": "2019-05-09T05:16:01Z",
"side": 1,
"message": "Looking into this further, will add once more understood",
"parentUuid": "dfbec78f_2d62e33f",
"range": {
"startLine": 73,
"startChar": 0,
"endLine": 73,
"endChar": 12
},
"revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_ad27b312",
@ -115,6 +211,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_7a172553",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 2
},
"lineNbr": 81,
"author": {
"id": 22604
},
"writtenOn": "2019-05-09T05:16:01Z",
"side": 1,
"message": "Done",
"parentUuid": "dfbec78f_ad27b312",
"range": {
"startLine": 81,
"startChar": 67,
"endLine": 81,
"endChar": 75
},
"revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_ed5b6b84",