airship
/
specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+1

(4 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 29624 2019-06-24 20:42:47 +00:00 committed by Gerrit Code Review
parent bd22875345
commit 2a7a0beae4
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
ca1e648b0f89f9ec98076fd567da0bd9b6b8ffd6 Normal file
View File

@ -0,0 +1,96 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_2b56012c",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 4
},
"lineNbr": 45,
"author": {
"id": 29624
},
"writtenOn": "2019-06-24T20:42:47Z",
"side": 1,
"message": "let\u0027s make sure this gets addressed before merging",
"range": {
"startLine": 45,
"startChar": 0,
"endLine": 45,
"endChar": 45
},
"revId": "ca1e648b0f89f9ec98076fd567da0bd9b6b8ffd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_0b377d01",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 4
},
"lineNbr": 94,
"author": {
"id": 29624
},
"writtenOn": "2019-06-24T20:42:47Z",
"side": 1,
"message": "should probably break these into a numbered list",
"range": {
"startLine": 84,
"startChar": 0,
"endLine": 94,
"endChar": 19
},
"revId": "ca1e648b0f89f9ec98076fd567da0bd9b6b8ffd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_ebbea963",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 4
},
"lineNbr": 94,
"author": {
"id": 29624
},
"writtenOn": "2019-06-24T20:42:47Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 94,
"startChar": 76,
"endLine": 94,
"endChar": 77
},
"revId": "ca1e648b0f89f9ec98076fd567da0bd9b6b8ffd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_cb3c05e3",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 4
},
"lineNbr": 111,
"author": {
"id": 29624
},
"writtenOn": "2019-06-24T20:42:47Z",
"side": 1,
"message": "returns what?",
"range": {
"startLine": 111,
"startChar": 0,
"endLine": 111,
"endChar": 13
},
"revId": "ca1e648b0f89f9ec98076fd567da0bd9b6b8ffd6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}