airship
/
specs
Code Issues Proposed changes

Update patch set 8 

Patch-set: 8
This commit is contained in:
Gerrit User 27715 2019-06-03 16:29:58 +00:00 committed by Gerrit Code Review
parent 959f6453c8
commit 27083313ba
1 changed files with 234 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

234
f234ecc056ffa020332fd51c5b0184e682fbcc53 Normal file
View File

@ -0,0 +1,234 @@
{
"comments": [
{
"key": {
"uuid": "bfb3d3c7_8a5de7ea",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 119,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "can this be shortened to --config? if we are distinguishing from e.g. --kube-config, can we nest that inside the --config?",
"range": {
"startLine": 119,
"startChar": 7,
"endLine": 119,
"endChar": 14
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_04ea200e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 267,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "documents",
"range": {
"startLine": 267,
"startChar": 33,
"endLine": 267,
"endChar": 41
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_653d73ba",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 289,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "Are shorthands more trouble than they are worth? Abbreviations often lead to conflicts (two options/commands which start with the same letter) as well as just lack of readability when the shorthand names are used in a script. If commands need to be manually run on a frequent enough basis (I don\u0027t think this is the case) to require shorthands, then that would likely pointsto issues with the command structure, or possibly overly long/hard-to-remember names.",
"range": {
"startLine": 289,
"startChar": 28,
"endLine": 289,
"endChar": 29
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_e4e02cfd",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 337,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "I think more useful than providing empty directory structures would be to provide actual reusable base document sets that can be layered on top of using e.g. kustomize, as well as example overlays, likely via a git repo, akin to treasuremap but with reusability.",
"range": {
"startLine": 335,
"startChar": 54,
"endLine": 337,
"endChar": 45
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_387d5e1c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 418,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "why not just use the argo CLI or even kubectl as desired? [0]:\n\n[0]: https://argoproj.github.io/docs/argo/examples/readme.html#argo-cli",
"range": {
"startLine": 418,
"startChar": 2,
"endLine": 418,
"endChar": 6
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f89d8666",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 422,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "wouldn\u0027t these just be accomplished by adding/removing the workflows in the site definition documents?",
"range": {
"startLine": 420,
"startChar": 0,
"endLine": 422,
"endChar": 52
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_18741a35",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 424,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "why not just use the argo CLI or even kubectl as desired? [0]:\n\n[0]: https://argoproj.github.io/docs/argo/examples/readme.html#argo-cli",
"range": {
"startLine": 424,
"startChar": 2,
"endLine": 424,
"endChar": 5
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_984a4a7e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 434,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "It looks like we are missing a command to actually invoke the workflows, how should that look?\n\nairshipctl sitemanage\nairshipctl workflow sitemanage\nairshipctl workflow submit sitemanage",
"range": {
"startLine": 434,
"startChar": 3,
"endLine": 434,
"endChar": 11
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_38f9de7f",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 436,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "apply?",
"range": {
"startLine": 436,
"startChar": 2,
"endLine": 436,
"endChar": 12
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_58693223",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 8
},
"lineNbr": 448,
"author": {
"id": 27715
},
"writtenOn": "2019-06-03T16:29:58Z",
"side": 1,
"message": "are there hooks available in metal3.io for this? if not should there be?",
"range": {
"startLine": 446,
"startChar": 35,
"endLine": 448,
"endChar": 30
},
"revId": "f234ecc056ffa020332fd51c5b0184e682fbcc53",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}