Update patch set 8

Patch Set 8: Code-Review-1

(2 comments)

I went ahead and started working on metric definition, object model, and prometheus integration in [0]. I believe the object model there should be largely reusable for CRD, logging, or any other export as well.

If we still would like to have a spec I think that is fine, but I just felt it was easiest to get straight into the implementation to determine what would actually work best.

[0]: https://review.opendev.org/#/c/668980/

Patch-set: 8
Label: Code-Review=-1

df36bc9e670be4b39e0a84b6b50828cea9625dab

@@ -0,0 +1,50 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "7faddb67_28a298af",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 8
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 27715
+      },
+      "writtenOn": "2019-07-10T22:03:04Z",
+      "side": 1,
+      "message": "the split between the tiller install/upgrade call and the armada wait logic is highly dependent on whether the tiller native wait logic is enabled (wait.native.enabled flag in armada/Chart doc). So I think the more useful metric is just the overall metric is the time from initial tiller install/upgrade to end of armada wait logic which can be considered the \"deployment time\".",
+      "range": {
+        "startLine": 13,
+        "startChar": 6,
+        "endLine": 13,
+        "endChar": 15
+      },
+      "revId": "df36bc9e670be4b39e0a84b6b50828cea9625dab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_488ef42e",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 8
+      },
+      "lineNbr": 23,
+      "author": {
+        "id": 27715
+      },
+      "writtenOn": "2019-07-10T22:03:04Z",
+      "side": 1,
+      "message": "simply logging them will not allow them to be scraped by Prometheus or exported to a CRD. They need to be stored in an explicit object model for that.",
+      "range": {
+        "startLine": 22,
+        "startChar": 42,
+        "endLine": 23,
+        "endChar": 29
+      },
+      "revId": "df36bc9e670be4b39e0a84b6b50828cea9625dab",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}