airship
/
specs
Code Issues Proposed changes

Update patch set 2 

Patch-set: 2
This commit is contained in:
Gerrit User 28618 2019-03-13 17:51:07 +00:00 committed by Gerrit Code Review
parent 3d4469d78a
commit 22096e8a92
1 changed files with 70 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
b52bf021d87a1d3fc69fd3f7071b2629ba850348
View File

@ -23,6 +23,53 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_9bbf1760",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 69,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T17:51:07Z",
"side": 1,
"message": "Agreed. The jobs should be renamed to match the pattern of the new ones coming in.",
"parentUuid": "5fc1f717_1bfb2779",
"range": {
"startLine": 68,
"startChar": 0,
"endLine": 69,
"endChar": 57
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_db56ff2a",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 73,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T17:51:07Z",
"side": 1,
"message": "Should this be optional? Since the FROM variable can be overridden, a Dockerfile.UBUNTU should theoretically be usable for both Ubuntu Bionic and Ubuntu Xenial.",
"range": {
"startLine": 70,
"startChar": 0,
"endLine": 73,
"endChar": 25
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_3b3dc32a",
@ -74,6 +121,29 @@
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_1b26c7cf",
"filename": "specs/approved/airship_multi_linux_distros.rst",
"patchSetId": 2
},
"lineNbr": 86,
"author": {
"id": 28618
},
"writtenOn": "2019-03-13T17:51:07Z",
"side": 1,
"message": "The playbooks do require an update to pass the DISTRO variable. This is the same pattern from OSH-images.",
"range": {
"startLine": 86,
"startChar": 2,
"endLine": 86,
"endChar": 14
},
"revId": "b52bf021d87a1d3fc69fd3f7071b2629ba850348",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}