airship
/
specs
Code Issues Proposed changes

Update patch set 11 

Patch Set 11: Code-Review-1

(5 comments)

looks pretty good. Some comments/questions for clarifications.

Patch-set: 11
Reviewer: Gerrit User 24580 <24580@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 24580 2019-09-03 20:23:39 +00:00 committed by Gerrit Code Review
parent 17a97b53af
commit 19efe49e04
1 changed files with 89 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
3adb97db3002b9743379fbe2a834acf6b612388e Normal file
View File

@ -0,0 +1,89 @@
{
"comments": [
{
"key": {
"uuid": "7faddb67_0842ee3b",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 113,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "Is this the path to the volume mounted in the container? is that useful for the subcommand?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_6851220d",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 118,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "If the iso image and k8s client config is always at the root of the mounted volume, is it still necessary to specify in the output-metadata.yaml?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_085bce21",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 124,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "wondering if possible to take certificates the user already has?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_6878427d",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 139,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "Do you mean modify the image in golang lib vs container?",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_c8ecd62a",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 11
},
"lineNbr": 148,
"author": {
"id": 24580
},
"writtenOn": "2019-09-03T20:23:39Z",
"side": 1,
"message": "maybe more specifically refer to the container image built form airship-images? e.g., \"based on Debian container from airship-images/...\"",
"revId": "3adb97db3002b9743379fbe2a834acf6b612388e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}