From 6c1b6e65b85897384bb0f642d1f43763e0b27178 Mon Sep 17 00:00:00 2001 From: Felipe Monteiro Date: Sun, 3 Mar 2019 11:46:44 -0500 Subject: [PATCH] zuul: Remove redundant airship-pegleg-tox-py36 job. The openstack-python36-jobs template already exists; thus there is no need for airship-pegleg-tox-py36. Since airship-pegleg-tox-py36 installs cfssl as a prerequisite for unit tests, move the install-cfssl.sh command to tox.ini prior to unit test execution, allowing for the airship-pegleg-tox-py36 Zuul job and its associated playbook to be removed. Change-Id: I66de957a1a57ef246476c1a81954cd0f822cb8be --- .zuul.yaml | 16 ---------------- tools/gate/playbooks/install-cfssl.yaml | 23 ----------------------- tox.ini | 2 ++ 3 files changed, 2 insertions(+), 39 deletions(-) delete mode 100644 tools/gate/playbooks/install-cfssl.yaml diff --git a/.zuul.yaml b/.zuul.yaml index 5b3c8c58..9356aca1 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -18,13 +18,11 @@ check: jobs: - openstack-tox-pep8 - - airship-pegleg-tox-py36 - airship-pegleg-doc-build - airship-pegleg-docker-build-gate gate: jobs: - openstack-tox-pep8 - - airship-pegleg-tox-py36 - airship-pegleg-doc-build - airship-pegleg-docker-build-gate post: @@ -37,20 +35,6 @@ - name: primary label: ubuntu-xenial -- job: - name: airship-pegleg-tox-py36 - description: | - Executes unit tests under Python 3.6 - parent: openstack-tox-py36 - pre-run: - - tools/gate/playbooks/install-cfssl.yaml - irrelevant-files: - - ^.*\.rst$ - - ^doc/.*$ - - ^etc/.*$ - - ^releasenotes/.*$ - - ^setup.cfg$ - - job: name: airship-pegleg-doc-build description: | diff --git a/tools/gate/playbooks/install-cfssl.yaml b/tools/gate/playbooks/install-cfssl.yaml deleted file mode 100644 index 360888f2..00000000 --- a/tools/gate/playbooks/install-cfssl.yaml +++ /dev/null @@ -1,23 +0,0 @@ -# Copyright 2018 AT&T Intellectual Property. All other rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -- hosts: all - gather_facts: False - tasks: - - name: Install cfssl for Ubuntu - shell: |- - ./tools/install-cfssl.sh - become: yes - args: - chdir: "{{ zuul.project.src_dir }}" diff --git a/tox.ini b/tox.ini index 14c6df7f..99b648c3 100644 --- a/tox.ini +++ b/tox.ini @@ -14,9 +14,11 @@ deps = -r{toxinidir}/test-requirements.txt passenv = http_proxy https_proxy HTTP_PROXY HTTPS_PROXY no_proxy NO_PROXY PBR_VERSION whitelist_externals = + bash find commands = find . -type f -name "*.pyc" -delete + bash -c "{toxinidir}/tools/install-cfssl.sh" {toxinidir}/tools/gate/run-unit-tests.sh '{posargs}' [testenv:fmt]