From 6a744d77ea1edca474dd54006d5414bc4f61fad3 Mon Sep 17 00:00:00 2001 From: Sean Eagan Date: Mon, 15 Oct 2018 16:30:35 -0500 Subject: [PATCH] Fix list releases paging Fix an issue where release paging failed to break out of the loop when no releases were found in tiller. Change-Id: I4a25e58a7f6bdd88941f7f87cba2a0aee261f8be --- armada/handlers/tiller.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/armada/handlers/tiller.py b/armada/handlers/tiller.py index 0b8ac26b..407383e4 100644 --- a/armada/handlers/tiller.py +++ b/armada/handlers/tiller.py @@ -211,7 +211,9 @@ class Tiller(object): response = stub.ListReleases( req, self.timeout, metadata=self.metadata) + found_message = False for message in response: + found_message = True page = message.releases if initial_total: @@ -232,6 +234,11 @@ class Tiller(object): else: done = True + # Ensure we break out was no message found which + # is seen if there are no releases in tiller. + if not found_message: + done = True + return releases for index in range(LIST_RELEASES_ATTEMPTS):