airship
/
airship-in-a-bottle
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(2 comments)

Patch-set: 6
Reviewer: Gerrit User 22477 <22477@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 22477 2019-12-02 22:32:17 +00:00 committed by Gerrit Code Review
parent 492ab03dc2
commit 9d57416f36
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
6cf8513ec606a02d07c43d9606db28ddc355d69c Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "3fa7e38b_c1f41e58",
"filename": "tools/multi_nodes_gate/airship_gate/lib/resolved.sh",
"patchSetId": 6
},
"lineNbr": 8,
"author": {
"id": 22477
},
"writtenOn": "2019-12-02T22:32:17Z",
"side": 1,
"message": "I think you need a -i or a tee here or else it will just cat the output to stdout",
"revId": "6cf8513ec606a02d07c43d9606db28ddc355d69c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_8194e6e8",
"filename": "tools/multi_nodes_gate/airship_gate/lib/resolved.sh",
"patchSetId": 6
},
"lineNbr": 14,
"author": {
"id": 22477
},
"writtenOn": "2019-12-02T22:32:17Z",
"side": 1,
"message": "do we still need for resolved to be running? If not, we could skip reconfiguring it and just disable it?",
"revId": "6cf8513ec606a02d07c43d9606db28ddc355d69c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}