Update patch set 11
Patch Set 11: Code-Review+1 (2 comments) Patch-set: 11 Reviewer: Gerrit User 30106 <30106@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1
This commit is contained in:
parent
95ed382b82
commit
5c94bdeb9a
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5faad753_4e359ef6",
|
||||
"filename": "tools/multi_nodes_gate/gate.sh",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 29,
|
||||
"author": {
|
||||
"id": 30106
|
||||
},
|
||||
"writtenOn": "2019-09-11T16:05:25Z",
|
||||
"side": 1,
|
||||
"message": "nit:\nbrackets could be made consistent here around GATE_MANIFEST and FINAL_STAGES, I don\u0027t think it really matters if you choose to add them to L23 or remove them from L27/L29.",
|
||||
"range": {
|
||||
"startLine": 23,
|
||||
"startChar": 0,
|
||||
"endLine": 29,
|
||||
"endChar": 102
|
||||
},
|
||||
"revId": "f8154492856a1ad88ed74e21735e0b4d5c15e1de",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5faad753_29385c9e",
|
||||
"filename": "tools/multi_nodes_gate/gate.sh",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 105,
|
||||
"author": {
|
||||
"id": 30106
|
||||
},
|
||||
"writtenOn": "2019-09-11T16:05:25Z",
|
||||
"side": 1,
|
||||
"message": "If you wanted to get really fancy here you could remove the if statement, and do\n\n run_stage_list \"$STAGES\"\n process_finalizers \"$?\"\n\nrather than using true/false strings. It would allow you handle different return codes/values in process_finalizers if that ever became important.",
|
||||
"range": {
|
||||
"startLine": 101,
|
||||
"startChar": 0,
|
||||
"endLine": 105,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "f8154492856a1ad88ed74e21735e0b4d5c15e1de",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue