Update patch set 26

Patch Set 26: Code-Review-1 (4 comments) Patch-set: 26 Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
2020-01-07 19:21:29 +00:00 · 2020-01-07 19:21:29 +00:00 · 4f912b1185
parent f5bcef395c
commit 4f912b1185
1 changed files with 92 additions and 0 deletions
--- a/92
+++ b/92
@ -35,6 +35,98 @@
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_70bfc0aa",
+        "filename": "tools/multi_nodes_gate/airship_gate/stages/build-scripts.sh",
+        "patchSetId": 26
+      },
+      "lineNbr": 42,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2020-01-07T19:21:29Z",
+      "side": 1,
+      "message": "Why leave this dead code in-place?",
+      "range": {
+        "startLine": 28,
+        "startChar": 0,
+        "endLine": 42,
+        "endChar": 52
+      },
+      "revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_d0c9d450",
+        "filename": "tools/multi_nodes_gate/airship_gate/stages/build-scripts.sh",
+        "patchSetId": 26
+      },
+      "lineNbr": 62,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2020-01-07T19:21:29Z",
+      "side": 1,
+      "message": "collect",
+      "range": {
+        "startLine": 62,
+        "startChar": 35,
+        "endLine": 62,
+        "endChar": 43
+      },
+      "revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_d0fc7440",
+        "filename": "tools/multi_nodes_gate/airship_gate/stages/build-scripts.sh",
+        "patchSetId": 26
+      },
+      "lineNbr": 71,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2020-01-07T19:21:29Z",
+      "side": 1,
+      "message": "Pegleg already verifies is a repository is valid. Is this check necessary?",
+      "range": {
+        "startLine": 70,
+        "startChar": 0,
+        "endLine": 71,
+        "endChar": 14
+      },
+      "revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_b06a1818",
+        "filename": "tools/multi_nodes_gate/airship_gate/stages/build-scripts.sh",
+        "patchSetId": 26
+      },
+      "lineNbr": 91,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2020-01-07T19:21:29Z",
+      "side": 1,
+      "message": "I\u0027d recommend using [0] instead of this function to cut down on your maintenance, but it\u0027s not required.\n\n[0] https://opendev.org/airship/pegleg/src/branch/master/tools/pegleg.sh",
+      "range": {
+        "startLine": 91,
+        "startChar": 0,
+        "endLine": 91,
+        "endChar": 22
+      },
+      "revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
    {
      "key": {
        "uuid": "3fa7e38b_95a1c3ab",