summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
13 daysAdd CLI passphrase generationHEADmasterAlexander Hughes
1. Add support to pegleg to generate a passphrase from CLI 2. Update unit test to ensure encryption/decryption supports passphrase rotation 3. Update order of import statements to satisfy pep8 4. Add unit test for CLI passphrase generation 5. Resolve merge conflicts via rebase Change-Id: I5cb9e41b2f0fac2451bd2b74f33c48cda417c22d Notes (review): Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+1: chittibabu <chittibabu1299@gmail.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Workflow+1: Bryan Strassner <strassner.bryan@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 05 Feb 2019 17:07:15 +0000 Reviewed-on: https://review.openstack.org/628021 Project: openstack/airship-pegleg Branch: refs/heads/master
2019-02-02Fix a tox mismatchTin Lam
This is patch set adds in a trivial fix for a mismatch between a comment and the actual hacking rule that is being enabled. Change-Id: I7b1b6146f0cc0222d050e9aabd42a965af63730f Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 04 Feb 2019 05:48:27 +0000 Reviewed-on: https://review.openstack.org/634580 Project: openstack/airship-pegleg Branch: refs/heads/master
2019-01-29CLI capability to generate and encrypt passphrasespallav
1. Adds the passphrases generation capability in Pegleg CLI, so that pegleg can generation random passwords based on a specification declared in pegleg/PassphrasesCatalog documents 2. Pegleg also wraps the generated passphrase documents in pegleg managed documents, and encrypts the data. 3. Adds unit test cases for passphrase generation. 4. Updates pegleg CLI document. Change-Id: I21d7668788cc24a8e0cc9cb0fb11df97600d0090 Notes (review): Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+1: Alexander Hughes <Alexander.Hughes@pm.me> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 31 Jan 2019 16:39:43 +0000 Reviewed-on: https://review.openstack.org/605425 Project: openstack/airship-pegleg Branch: refs/heads/master
2019-01-26Merge "pki: Port Promenade's PKI catalog into Pegleg"Zuul
2019-01-23Typo fix: getting started URLRoman Gorshunov
Change-Id: Ia1082d2625c37570907cea07d4437ab24e5376a2 Notes (review): Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 24 Jan 2019 19:11:19 +0000 Reviewed-on: https://review.openstack.org/632647 Project: openstack/airship-pegleg Branch: refs/heads/master
2019-01-15pki: Port Promenade's PKI catalog into PeglegFelipe Monteiro
This patch set implements the PKICatalog [0] requirements as well as PeglegManagedDocument [1] generation requirements outlined in the spec [2]. Included in this patch set: * New CLI entry point called "pegleg site secrets generate-pki" * PeglegManagedDocument generation logic in engine.cache.managed_document * Refactored PKICatalog logic in engine.cache.pki_catalog derived from the Promenade PKI implementation [3], responsible for generating certificates, CAs, and keypairs * Refactored PKIGenerator logic in engine.cache.pki_generator derived from Promenade Generator implementation [4], responsible for reading in pegleg/PKICatalog/v1 documents (as well as promenade/PKICatalog/v1 documents for backwards compatibility) and generating required secrets and storing them into the paths specified under [0] * Unit tests for all of the above [5] * Example pki-catalog.yaml document under pegleg/site_yamls * Validation schema for pki-catalog.yaml (TODO: implement validation logic here: [6]) * Updates to CLI documentation and inclusion of PKICatalog and PeglegManagedDocument documentation * Documentation updates with PKI information [7] TODO (in follow-up patch sets): * Expand on overview documentation to include new Pegleg responsibilities * Allow the original repository (not the copied one) to be the destination where the secrets are written to * Finish up cert expiry/revocation logic [0] https://airship-specs.readthedocs.io/en/latest/specs/approved/pegleg-secrets.html#document-generation [1] https://airship-specs.readthedocs.io/en/latest/specs/approved/pegleg-secrets.html#peglegmanageddocument [2] https://airship-specs.readthedocs.io/en/latest/specs/approved/pegleg-secrets.html [3] https://github.com/openstack/airship-promenade/blob/master/promenade/pki.py [4] https://github.com/openstack/airship-promenade/blob/master/promenade/generator.py [5] https://review.openstack.org/#/c/611739/ [6] https://review.openstack.org/#/c/608159/ [7] https://review.openstack.org/#/c/611738/ Change-Id: I3010d04cac6d22c656d144f0dafeaa5e19a13068 Notes (review): Code-Review+1: Michael Beaver <michaelbeaver64@gmail.com> Code-Review+1: Alexander Hughes <Alexander.Hughes@pm.me> Code-Review+1: chittibabu <chittibabu1299@gmail.com> Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review-1: Tin Lam <tin@irrational.io> Code-Review+2: Matt McEuen <matt.mceuen@att.com> Workflow+1: Matt McEuen <matt.mceuen@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 26 Jan 2019 00:29:39 +0000 Reviewed-on: https://review.openstack.org/606131 Project: openstack/airship-pegleg Branch: refs/heads/master
2019-01-01tests: Increase test coverage for lint checksFelipe Monteiro
This patch set expands on the unit test coverage for lint checks in test_selectable_linting which only covers a small subset of the lint checks handled by Pegleg. This logic should be properly tested as linting is fundamental to Pegleg functionality. Change-Id: I6a59295982abd22bba8036827cefd4186b68e2fb Notes (review): Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Code-Review+1: Lev Morgan <morgan.lev@gmail.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 02 Jan 2019 15:39:23 +0000 Reviewed-on: https://review.openstack.org/614015 Project: openstack/airship-pegleg Branch: refs/heads/master
2019-01-01Merge "docs: Document all Pegleg lint codes"Zuul
2019-01-01Merge "Update docs to replace `aic-site-clcp-manifests` with ↵Zuul
`airship-treasuremap`"
2019-01-01Add hacking extensionTin Lam
This patch set adds hacking rule to pegleg and fixes outstanding non- docstring related violations. Change-Id: I5bb5e78c211f24cf95669124bfcf9603bea8bf15 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+1: Chris Wedgwood <cw@f00f.org> Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 01 Jan 2019 18:13:07 +0000 Reviewed-on: https://review.openstack.org/619981 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-12-26Update docs to replace `aic-site-clcp-manifests` with `airship-treasuremap`Evgeny L
Change-Id: Ic53d5d768fcecaac07b4703ce818fe73a52d1c56 Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 01 Jan 2019 18:13:08 +0000 Reviewed-on: https://review.openstack.org/627422 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-12-23Merge "trivial: fix whitespace-linter catching false positives"Zuul
2018-12-04Merge "Add releasenotes"Zuul
2018-11-28Add releasenotesTin Lam
This patch set adds releasenotes (reno) to the airship-pegleg repository. Change-Id: I1ed98460f40eb851ca53f8a5b68ab17f8272a2e2 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+1: Rick Bartra <rb560u@att.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 04 Dec 2018 20:43:56 +0000 Reviewed-on: https://review.openstack.org/620534 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-27CLI: Add support for uploading documents to ShipyardNishant Kumar
This PS enables Pegleg to upload documents directly to Shipyard thus ensuring that unencrypted data never gets stored in disk. The flow for this new CLI command is as follows: - Collect documents as per the provided site repository - Decrypt the collected documets(TODO) - Upload document to Shipyard: - one collection per repository will be uploaded to Shipyard Eg- pegleg site -r /opt/aic-clcp-site-manifests \ -e global=/opt/aic-clcp-manifests upload <site-name> Two collections will be created in shipyard since there are two repositories provided. The name of the collections will be the name of repositories provided. - Commit the documents in shipyard buffer. Change-Id: I6275252b044ebb82d8bb2009c0bea6ebf7033bce Notes (review): Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Workflow+1: Bryan Strassner <strassner.bryan@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 04 Dec 2018 17:22:06 +0000 Reviewed-on: https://review.openstack.org/609546 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-27Fix link addresseszhangdebo
Change-Id: I7086b4cac5e3bcd2ac2a1958b678615e05ccbd1d Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 27 Nov 2018 16:45:21 +0000 Reviewed-on: https://review.openstack.org/620300 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-25docs: Document all Pegleg lint codesFelipe Monteiro
This adds Pegleg's lint codes to the operator documentation to obviously assist operators with figuring out failing Pegleg lint checks. Change-Id: I6742af48c563f6dd4b4f1d363b678cdcd000347e Notes (review): Code-Review+1: Tin Lam <tin@irrational.io> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Code-Review+1: Lev Morgan <morgan.lev@gmail.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 01 Jan 2019 18:13:08 +0000 Reviewed-on: https://review.openstack.org/614013 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-25trivial: fix whitespace-linter catching false positivesFelipe Monteiro
Ignores .pyc files and files contained in htmlcov as a coverage job was recently added. Change-Id: I33b1b88e90060f3b26f41b6acbbc0c7091caeb57 Notes (review): Code-Review+1: Tin Lam <tin@irrational.io> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sun, 23 Dec 2018 18:55:01 +0000 Reviewed-on: https://review.openstack.org/619937 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-13Flake8 fixTin Lam
This removes all PEP8 ignores and places in default settings for flake8. Change-Id: I3c4df02dea959dfe58f44e7c0e0ac58078a81abc Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 22:48:52 +0000 Reviewed-on: https://review.openstack.org/617233 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-13Merge "Fix URLs"Zuul
2018-11-13Merge "Adding missing format character"Zuul
2018-11-13Merge "Refactor Pegleg exceptions"Zuul
2018-11-13Merge "Consolidate linter jobs"Zuul
2018-11-13Refactor Pegleg exceptionsTin Lam
This patch set cleans up the current implementation of pegleg. As all the git exceptions inconsistently inits or override the message. This also cleans up a handful of incorrect kwarg keywords, and improve handling of the exception messages. Change-Id: I438eb032728c71cbf972c2120a76d06106cb1580 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 16:50:49 +0000 Reviewed-on: https://review.openstack.org/617445 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-12Merge "Remove the duplicated "and"."Zuul
2018-11-12Remove the duplicated "and".zhangzs
Change-Id: I7cba441990d5bf67548982f2a2738e43f0a28b27 Notes (review): Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+2: Roman Gorshunov <roman.gorshunov@att.com> Workflow+1: Roman Gorshunov <roman.gorshunov@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 12 Nov 2018 10:35:07 +0000 Reviewed-on: https://review.openstack.org/617257 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-12Consolidate linter jobsTin Lam
Consolidating all the linting to a single job rather than having a one-off just to lint for trailing whitespaces. As most of this projects are python, this should already be covered by PEP8, but will be scanning for yamls with trailing whitespaces. Change-Id: Iee33a69ff234d21c08217faa33a19e11dfef0ad9 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 15:52:49 +0000 Reviewed-on: https://review.openstack.org/617247 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-11Merge "Remove py35 support"Zuul
2018-11-09Fix URLsTin Lam
This patch set sanitizes and changes the default proxy URLs. Change-Id: Ibaeb501b59eeea8427fa812078236cfc4fe39623 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 17:44:58 +0000 Reviewed-on: https://review.openstack.org/616990 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-08Only collect/parse Deckhand-formatted documents for processingFelipe Monteiro
This patch set changes Pegleg in two similar ways: 1) Ignore certain types of files altogether: - those located in hidden folders - those prefixed with "." (files like .zuul.yaml) 2) Only read Deckhand-formatted documents for lint/collect/etc. commands as Pegleg need not consider other types of documents (it separately reads the site-definition.yaml for internal processing still). The tools/ subfolder is also ignored as it can contain .yaml files which are not Deckhand-formatted documents, so need not be processed by pegleg.engine. Change-Id: I8996b5d430cf893122af648ef8e5805b36c1bfd9 Notes (review): Code-Review+1: Tin Lam <tin@irrational.io> Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+1: Ahmad Mahmoudi <am495p@att.com> Code-Review+2: Bryan Strassner <bryan.strassner@gmail.com> Workflow+1: Bryan Strassner <bryan.strassner@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 09 Nov 2018 20:00:27 +0000 Reviewed-on: https://review.openstack.org/614621 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-08Minor: meaningful default labelRoman Gorshunov
Making default label meaningful and conformant to "key=value" requirement. Change-Id: Ibb915e3333d74f61742fbb9c4f3c7851d2fef040 Notes (review): Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 08 Nov 2018 19:06:24 +0000 Reviewed-on: https://review.openstack.org/616664 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-07Merge "Update decrypt secrets to return a list of docs"Zuul
2018-11-07Remove py35 supportTin Lam
As the default Docker image support for Pegleg is using py36 as a base image, this patch set simply removes the support for py35. This allows us to use py36 features such as secrets and f-strings without needing to cope with backward compatibility. Change-Id: Ic156ca67d2a0fe6fdc74c2c9da253a1cb8a3f456 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sun, 11 Nov 2018 22:22:13 +0000 Reviewed-on: https://review.openstack.org/614584 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-06Add coverage jobTin Lam
This patch set adds in a python coverage job for pegleg using pytest. Change-Id: Ice0332cc454f488e0372d5ab03e8b0a37db9efd1 Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 07 Nov 2018 16:03:10 +0000 Reviewed-on: https://review.openstack.org/616024 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-06Update decrypt secrets to return a list of docsAhmad Mahmoudi
1. Added the method to decrypt a secret file and return its contents as a list of documents (instead of printing out the file content). 2. Added clarifications for a encrypt and decrypt commands. Change-Id: I77bce21be214c880c8413f5e6a2d0c2d1993fc8e Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+2: Bryan Strassner <bryan.strassner@gmail.com> Workflow+1: Bryan Strassner <bryan.strassner@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 07 Nov 2018 20:49:49 +0000 Reviewed-on: https://review.openstack.org/614695 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-02Adding missing format characterLev Morgan
It looks like there's a missing % in pegleg/engine/util/definition.py, where pluck creates its ClickException. This adds it in. Change-Id: I26c12423af11f7d02944a077f762bcdd1e03be41 Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+1: Tin Lam <tin@irrational.io> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 16:50:50 +0000 Reviewed-on: https://review.openstack.org/615299 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-11-02Merge "FIX: Passing correct fields to process site"Zuul
2018-10-31Update .gitignoreTin Lam
Update the .gitignore to be more comprehensive and that it is more inline with airship-deckhand's .gitignore. Change-Id: I0f2860034d060461a441be65feea274ef1fef30a Signed-off-by: Tin Lam <tin@irrational.io> Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Workflow+1: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 31 Oct 2018 21:29:38 +0000 Reviewed-on: https://review.openstack.org/614630 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-10-31FIX: Passing correct fields to process siteNishant Kumar
This PS passes correct fields which is required for processing site_definiton.yaml appropriately. Change-Id: I546caa1a034fe1fd05c3568137982cb7b4ef7bec Notes (review): Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Code-Review+1: Vladyslav Drok <vdrok@mirantis.com> Code-Review+1: Rick Bartra <rb560u@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 02 Nov 2018 15:03:04 +0000 Reviewed-on: https://review.openstack.org/614541 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-10-30Merge "Pegleg encryption of site secrets"Zuul
2018-10-30Pegleg encryption of site secretsAhmad Mahmoudi
Added secret encryption/decryption to pegleg cli. Change-Id: I95b993748d99fc4398eee1d1c59e74f382497f74 Notes (review): Code-Review+1: Bryan Strassner <bryan.strassner@gmail.com> Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+2: Matt McEuen <matt.mceuen@att.com> Workflow+1: Matt McEuen <matt.mceuen@att.com> Code-Review+2: Felipe Monteiro <felipe.monteiro@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 30 Oct 2018 21:18:39 +0000 Reviewed-on: https://review.openstack.org/608110 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-10-29trivial: Drop unused lint code P002Felipe Monteiro
This patch set drops unused lint code P002 from Pegleg. The variable for P002 is called: DECKHAND_RENDERING_INCOMPLETE_FLAG It is not clear what this even means, so the assumption here is that it is a mishap so there is nothing to implement behind the scenes. The recourse is to remove it. Change-Id: I3bc99e5f48aa1fa9ea652f073fd4e147b4283e10 Notes (review): Code-Review+2: Kaspars Skels <kaspars.skels@gmail.com> Code-Review+1: Tin Lam <tin@irrational.io> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 30 Oct 2018 20:02:55 +0000 Reviewed-on: https://review.openstack.org/614046 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-10-29Merge "refactor: Use temp path fixture to automatically clean up"Zuul
2018-10-29Merge "refactor: Allow site_by_params to take in list of fields"Zuul
2018-10-29Merge "docs: Add docstring information for pegleg.config"Zuul
2018-10-29Merge "refactor: Add convenient callback for processing site repos"Zuul
2018-10-29Merge "refactor: Exchange NotADirectoryError for better exception"Zuul
2018-10-29refactor: Use temp path fixture to automatically clean upFelipe Monteiro
This patch set refactors uses of tempfile.mkdtemp() used throughout many tests in Pegleg which leaves lingering temporary directories around. Recently a fixture was introduced in [0] which automatically cleans up after itself. This patch set applies the fixture everywhere possible to minimize the testing footprint. [0] https://review.openstack.org/#/c/609818/20/tests/unit/fixtures.py Change-Id: Id4c1195c4f248b974a5396a429d651943a84ee83 Notes (review): Code-Review+2: Craig Anderson <craig.anderson@att.com> Workflow+1: Craig Anderson <craig.anderson@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 29 Oct 2018 18:32:25 +0000 Reviewed-on: https://review.openstack.org/612738 Project: openstack/airship-pegleg Branch: refs/heads/master
2018-10-27Merge "Allow tox to support regexes for unit tests"Zuul
2018-10-27Merge "fix: Always check for exit_code 0 in CLI tests"Zuul