Consolidate linter jobs

Consolidating all the linting to a single job rather than having a one-off
just to lint for trailing whitespaces. As most of this projects are python,
this should already be covered by PEP8, but will be scanning for yamls with
trailing whitespaces.

Change-Id: Iee33a69ff234d21c08217faa33a19e11dfef0ad9
Signed-off-by: Tin Lam <tin@irrational.io>
This commit is contained in:
Tin Lam 2018-11-12 02:26:22 -06:00
parent 03634de6c8
commit 152b42bc3b
4 changed files with 16 additions and 29 deletions

View File

@ -17,13 +17,11 @@
check:
jobs:
- openstack-tox-pep8
- airship-pegleg-linter
- airship-pegleg-doc-build
- airship-pegleg-docker-build-gate
gate:
jobs:
- openstack-tox-pep8
- airship-pegleg-linter
- airship-pegleg-doc-build
- airship-pegleg-docker-build-gate
post:
@ -36,13 +34,6 @@
- name: primary
label: ubuntu-xenial
- job:
name: airship-pegleg-linter
description: |
Lints all files by checking them for whitespace.
run: tools/gate/playbooks/zuul-linter.yaml
nodeset: airship-pegleg-single-node
- job:
name: airship-pegleg-doc-build
description: |

View File

@ -1,20 +0,0 @@
# Copyright 2017 The Openstack-Helm Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
- hosts: primary
tasks:
- name: Execute a Whitespace Linter check
command: find . -not -path "*/\.*" -not -path "*/doc/build/*" -not -path "*/doc/source/images/*" -not -name "*.tgz" -type f -exec egrep -l " +$" {} \;
register: result
failed_when: result.stdout != ""

13
tools/gate/whitespace-linter.sh Executable file
View File

@ -0,0 +1,13 @@
#!/usr/bin/env bash
set -xe
RES=$(find . \
-not -path "*/\.*" \
-not -path "*/doc/build/*" \
-not -path "*/doc/source/images/*" \
-not -name "*.tgz" \
-type f -exec egrep -l " +$" {} \;)
if [[ -n $RES ]]; then
exit 1;
fi

View File

@ -31,8 +31,11 @@ basepython = python3
deps =
-r{toxinidir}/test-requirements.txt
commands =
bash -c "{toxinidir}/tools/gate/whitespace-linter.sh"
bandit -r pegleg -n 5
flake8 {toxinidir}/pegleg
whitelist_externals =
bash
[testenv:docs]
basepython = python3