Commit Graph

3 Commits

Author SHA1 Message Date
Felipe Monteiro b03a4522cb fix: Use schema instead of metadata.schema for replacement check
Recently added replacement check incorrectly uses metadata.schema
and metadata.name to key on the document -- but it should be schema
and metadata.name, the combination of which uniquely defines a
document.

Change-Id: I6cd1679ad41be38cb78d65ce2763e60f7da390d2
2018-10-31 15:02:28 -04:00
Rick Bartra 60e82b7bd6 Validate additional 'metadata.replacement' scenarios
This patch set adds additional documentation and unit tests
to validate further replacement scenarios.

In particular this commit adds an additional document check that
looks for documents exisitng in different layers that contain the
same name and same schema without any of them having `replacement: true`

Change-Id: I7c033d32a6755f36e609789a748cbc6d4af06bc2
2018-10-30 10:23:14 -04:00
Felipe Monteiro 24d86ea749 refactor: Move replacement checks into separate module
This patch set refactors replacement validation checks
in Deckhand's layering module into a separate module for
better code organization.

Change-Id: If973148ac8220b96f61128b8a7266e6fd57e76b9
2018-10-20 17:08:16 -04:00