summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
4 daysFix pep8 errorsHEADmasterMichael Beaver
This addresses the pep8 errors that are causing gate failures Change-Id: Id92dbbf527af1953026f17ddb3f2d79f0a635284 Notes (review): Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+1: Vladyslav Drok <vdrok@mirantis.com> Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 18 Feb 2019 22:24:36 +0000 Reviewed-on: https://review.openstack.org/637116 Project: openstack/airship-armada Branch: refs/heads/master
11 daysMerge "Revert "Use UBUNTU_BASE_IMAGE instead of BASE_IMAGE""Zuul
11 daysRevert "Use UBUNTU_BASE_IMAGE instead of BASE_IMAGE"Sean Eagan
This reverts commit 5071ef0ca565e09946a6fddc83867222404e8729. Change-Id: Ic319728902d772e2c3d34a702839501d0d3fdca9 Notes (review): Code-Review+1: Dustin Specker <dustin.specker@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 08 Feb 2019 21:28:06 +0000 Reviewed-on: https://review.openstack.org/635916 Project: openstack/airship-armada Branch: refs/heads/master
11 daysDefend against uninitialized fields in k8s objectsSean Eagan
Much of these may be unnecessary, but this code was adapted from go code which handles uninitialized values better via "zero values", also the k8s python client docs show most of these fields as "optional". Hence, initializing leaf values in these model objects to avoid further surprises. Change-Id: Ib646b56dfe1ff83f0ecbedaf73fcde8ffa2be0cf Notes (review): Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+1: Dan Crank <dan.no@att.com> Workflow+1: Bryan Strassner <strassner.bryan@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 08 Feb 2019 17:55:44 +0000 Reviewed-on: https://review.openstack.org/635713 Project: openstack/airship-armada Branch: refs/heads/master
11 dayswait: Verify observed_generation existsDrew Walters
Currently, Armada checks if the observed generation of a resource is zero for resource wait operations; however, the value can be None in some cases. This change verifies that the value is not zero and exists. Change-Id: Ib81be3468e73c72b4f20c11e18120d8a5b845e59 Notes (review): Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+2: Sean Eagan <sean.eagan@att.com> Workflow+1: Sean Eagan <sean.eagan@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 08 Feb 2019 05:34:21 +0000 Reviewed-on: https://review.openstack.org/635704 Project: openstack/airship-armada Branch: refs/heads/master
13 daysUse UBUNTU_BASE_IMAGE instead of BASE_IMAGEBryan Strassner
Offering better alignment with some downstream build jobs. Change-Id: Ide49c08df1f1d0ff8cf570500f2285bc152ed32a Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 07 Feb 2019 20:56:40 +0000 Reviewed-on: https://review.openstack.org/635353 Project: openstack/airship-armada Branch: refs/heads/master
2019-02-04Merge "Update missed refs to tiller 2.12.1"Zuul
2019-02-04Merge "Add airship-discuss@lists.airshipit.org"Zuul
2019-02-04Merge "Switch to ubuntu base image"Zuul
2019-01-31Merge "Add configurability of delete timeout"Zuul
2019-01-31Merge "Move grpc tools to test requirements"Zuul
2019-01-30Switch to ubuntu base imageSean Eagan
Change to use ubuntu base image instead of python. Also refactor Dockerfile to remove unnecessary build dependencies to reduce size. BREAKING CHANGE: The `make images` PYTHON_BASE_IMAGE arg is now renamed to BASE_IMAGE. Change-Id: I63556290d8e007bfac4315529261d75e362806d6 Notes (review): Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 04 Feb 2019 16:31:57 +0000 Reviewed-on: https://review.openstack.org/634044 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-29Add configurability of delete timeoutSean Eagan
Previously the timeout for deleting chart releases was 300s and not configurable, this patchset makes it so via a new `delete.timeout` property in the `armada/Chart/v1` schema. Helm releases deleted which do not correspond to documents in this schema still do not use a configurable timeout. Those will be considered separately. This also includes a minor logging fix. Change-Id: Ia588faaafd18a3ac00eed3cda2f0556ffcec82c9 Notes (review): Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+2: Pete Birley <petebirley@gmail.com> Workflow+1: Pete Birley <petebirley@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 31 Jan 2019 21:26:18 +0000 Reviewed-on: https://review.openstack.org/630779 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-29Move grpc tools to test requirementsSean Eagan
Grpc tools is only needed for `make protoc` to generate the tiller grpc code. This will result in it being removed from Armada's docker image as well as Shipyard's once the Armada git reference is uplifted there to include this change. Change-Id: Iede466db4fd2d157c2f86235dc6b6e35c706d8d8 Notes (review): Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 31 Jan 2019 16:06:02 +0000 Reviewed-on: https://review.openstack.org/633809 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-29Merge "Automate deletion of test pods"Zuul
2019-01-29Merge "CI: Add chart build gate"Zuul
2019-01-28Update missed refs to tiller 2.12.1Sean Eagan
Update tiller version refs missed in the initial uplift [0]. [0]: https://review.openstack.org/#/c/630325/ Change-Id: I891d1a7ddcecdd25f0bdc5a95dc5301e79c7714c Notes (review): Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+2: Kaspars Skels <kaspars.skels@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Code-Review+1: Lev Morgan <morgan.lev@gmail.com> Code-Review+1: Alexander Hughes <Alexander.Hughes@pm.me> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 04 Feb 2019 20:28:16 +0000 Reviewed-on: https://review.openstack.org/633600 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-28Automate deletion of test podsSean Eagan
When running helm tests for a chart release multiple times in a site, if the previous test pod is not deleted, then the test pod creation can fail due to a name conflict. Armada/helm support immediate test pod cleanup, but using this means that upon test failure, the test pod logs will not be available for debugging purposes. Due to this, the recommended approach for deleting test pods in Armada has been using `upgrade.pre.delete` actions. So chart authors can accomplish test pod deletion using this feature, however, it often takes awhile, usually not until they test upgrading the chart for chart authors to realize that this is necessary and to get it implemented. This patchset automates deletion of test pods directly before running tests by using the `wait.labels` field in the chart doc when they exist to find all pods in the release and then using their annotations to determine if they are test pods and deleting them if so. A later patchset is planned to implement defaulting of the wait labels when they are not defined. Change-Id: I2092f448acb88b5ade3b31b397f9c874c0061668 Notes (review): Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 29 Jan 2019 17:29:12 +0000 Reviewed-on: https://review.openstack.org/629313 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-28Merge "Remediate releases stuck in non-DEPLOYED statuses"Zuul
2019-01-28CI: Add chart build gateDrew Walters
This commit introduces a chart build gate that triggers when changes are made to charts in the charts/ directory. Change-Id: Ieec10c36adfd0538e70ac47ad30ce314f24f712f Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Workflow+1: Bryan Strassner <strassner.bryan@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 29 Jan 2019 15:41:44 +0000 Reviewed-on: https://review.openstack.org/633537 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-25Merge "Fix the description about `armada tiller --status`"Zuul
2019-01-20Add airship-discuss@lists.airshipit.org98k
Change-Id: Ic71f1a80ed78cee5d447e1834d931dc481f2e57a Notes (review): Code-Review+1: Filippo Inzaghi <zhao.daqing@99cloud.net> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+1: Andriy Shevchenko <huang.zhiping@99cloud.net> Code-Review+1: Evgeniy L <eli@mirantis.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 04 Feb 2019 16:38:15 +0000 Reviewed-on: https://review.openstack.org/622994 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-18Remediate releases stuck in non-DEPLOYED statusesSean Eagan
Armada remediates releases stuck in FAILED status, if not protected, by purging and re-installing them. This implements the same for other non-DEPLOYED statuses. For these statuses it guards this with a best effort determination of whether a previous deployment of the release, either through armada or the helm CLI, is likely still pending based on whether it was last deployed within the chart's wait timeout. If it is deemed likely pending an error is raised, however this condition will eventually expire on future runs allowing for eventual remediation. Reasons why a release may get stuck in statuses other than DEPLOYED or FAILED include: 1. tiller crashed mid-deployment 2. tiller could not reach kubernetes to update the release state 3. running `helm delete <rel>` (without --purge) (DELETED status) Change-Id: Ia89cd59f056103dde47980a149c07a2984c4bbb4 Notes (review): Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Workflow+1: Bryan Strassner <strassner.bryan@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 28 Jan 2019 18:15:50 +0000 Reviewed-on: https://review.openstack.org/631328 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-18Merge "bugfix: Looking in wrong place for upgrade options"Zuul
2019-01-18bugfix: Looking in wrong place for upgrade optionsSean Eagan
Fixes a bug where Armada Was looking for upgrade options (force, recreate_pods currently) underneath `upgrade` directly rather than `upgrade.options` where they are defined in the schema. Change-Id: Ia95129a19c87f5d59eaefccd04a7ac9e2acb0b3b Notes (review): Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 18 Jan 2019 22:52:15 +0000 Reviewed-on: https://review.openstack.org/631891 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-17CI: Remove OpenStack-Helm-Infra CI jobDrew Walters
Currently, the airship-armada-ubuntu job deploys K8s using outdated playbooks. The job fails due to a change [0] that introduced an AppArmor requirement to Calico. This change removes the failing job, as its success does not depend on changes in Armada. In the future, jobs requiring K8s should be deployed using playbooks from Airship-Treasuremap [1]. [0] https://review.openstack.org/614805 [1] https://git.openstack.org/cgit/openstack/airship-treasuremap/tree/tools/deployment/airskiff/developer/010-deploy-k8s.sh Change-Id: I40dc1e0ccfd956c157a6bef60f106eb9c5e9ca04 Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 18 Jan 2019 22:40:16 +0000 Reviewed-on: https://review.openstack.org/630752 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-11Move to tiller 2.12.1Sean Eagan
Tiller 2.12 [0] adds: - kubernetes 1.11 support - fix for a concurrency issue [1] [0]: https://github.com/helm/helm/releases/tag/v2.12.0 [1]: https://github.com/helm/helm/pull/4828 Change-Id: I99ddd9d105b81177d3b7e5691afebbcca97c119f Notes (review): Code-Review+1: Nishant Kumar <nishant.e.kumar@ericsson.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Matt McEuen <matt.mceuen@att.com> Workflow+1: Matt McEuen <matt.mceuen@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Sat, 12 Jan 2019 01:27:52 +0000 Reviewed-on: https://review.openstack.org/630325 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-04Merge "Adding filename to logging message format for troubleshooting purpose "Zuul
2019-01-04Adding filename to logging message format for troubleshooting purpose pd2839
Change-Id: I5edd13d2a2c06f844bef1595e045208f53af4e71 Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+1: Rahul Khiyani <rk0850@att.com> Code-Review+1: Evgeniy L <eli@mirantis.com> Code-Review+2: Matt McEuen <matt.mceuen@att.com> Workflow+1: Matt McEuen <matt.mceuen@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 22:28:07 +0000 Reviewed-on: https://review.openstack.org/627411 Project: openstack/airship-armada Branch: refs/heads/master
2019-01-04Merge "Add chart about rabbitmq and remove timeout from example"Zuul
2019-01-04Fix the misspelling of "except"lijunjie
Change-Id: Iabfe5a9b2a99e32ab975257fe5db2bd3b29d26bf Notes (review): Code-Review+1: Evgeniy L <eli@mirantis.com> Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 18:23:26 +0000 Reviewed-on: https://review.openstack.org/628390 Project: openstack/airship-armada Branch: refs/heads/master
2018-12-10Fix the description about `armada tiller --status`pengdake
Change-Id: I61053aed3143f788048718ee5e06c9a897cd1fbe Signed-off-by: pengdake <19921207pq@gmail.com> Notes (review): Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+1: Evgeniy L <eli@mirantis.com> Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 25 Jan 2019 15:53:03 +0000 Reviewed-on: https://review.openstack.org/623412 Project: openstack/airship-armada Branch: refs/heads/master
2018-12-05Add chart about rabbitmq and remove timeout from examplepengdake
1. According to https://github.com/openstack/openstack-helm/blob/master/keystone/templates/job-rabbit-init.yaml, We need to add chart about rabbitmq. 2. Timeout is overridden by `wait.timout`, we should remove it from example manifest. Change-Id: Ia455886b2d2666e15a3454e9208cae89c3140826 Signed-off-by: pengdake <19921207pq@gmail.com> Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+1: Evgeniy L <eli@mirantis.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 04 Jan 2019 18:24:55 +0000 Reviewed-on: https://review.openstack.org/621491 Project: openstack/airship-armada Branch: refs/heads/master
2018-12-04Merge "test: Refactor test handler"Zuul
2018-11-30Merge "Log full exception chain of chart deploy exceptions"Zuul
2018-11-30Update manifest named keystone-manifestpengdake
The charts of mariadb and memcached are moved to openstack-helm-infra. So we need update keystone-manifest. Change-Id: Ie5cb4fcc5bf7b1dc31880eef6fbb6d0600598680 Signed-off-by: pengdake <19921207pq@gmail.com> Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 30 Nov 2018 19:52:54 +0000 Reviewed-on: https://review.openstack.org/621063 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-29test: Refactor test handlerDrew Walters
While authoring [0], it was discovered that Armada has duplicate logic for deciding if Helm test cleanup should be enabled as well as the tests themselves. Because of this, changes to test logic (e.g. adding pre-test actions), requires changing all traces of the repeated logic, which can lead to inconsistent behavior if not properly addressed. This change moves all test decision logic to a singular Test handler, implemented by the `Test` class. This change does NOT change the expected behavior of testing during upgrades; however, tests initiated from the API and CLI will not execute when testing a manifest if they are disabled in a chart, unless using the `--enable-all` flag. [0] https://review.openstack.org/617834 Change-Id: I1530d7637b0eb6a83f048895053a5db80d033046 Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 04 Dec 2018 20:40:54 +0000 Reviewed-on: https://review.openstack.org/618355 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-26Workaround kubernetes python client deadlock issueSean Eagan
The kubernetes python client has a bug [1] which results in frequent deadlocks while being cleaned up, which causes armada to hang at the end of execution. This patchset works around that issue by mocking out the associated thread pools, since they are only needed for async kubernetes api calls, which armada does not use. [1]: https://github.com/kubernetes-client/python/issues/411 Change-Id: I71fbfbe355347ae2ddd02ffd26d881368320246b Notes (review): Code-Review+1: Kaspars Skels <kaspars.skels@gmail.com> Code-Review+1: Dustin Specker <dustin.specker@att.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+2: Bryan Strassner <bryan.strassner@gmail.com> Workflow+1: Bryan Strassner <bryan.strassner@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 29 Nov 2018 22:56:16 +0000 Reviewed-on: https://review.openstack.org/620169 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-16Log full exception chain of chart deploy exceptionsSean Eagan
Change-Id: Ice563ed365e57d0521f6e0d319651a27805f1eee Notes (review): Code-Review+2: Mark Burnett <mark.m.burnett@gmail.com> Code-Review+1: Rick Bartra <rb560u@att.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 30 Nov 2018 19:52:55 +0000 Reviewed-on: https://review.openstack.org/618591 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-14Merge "tiller: Remove unused params from delete_resources"Zuul
2018-11-14Merge "Create Makefile target to install Helm binary"Zuul
2018-11-13tiller: Remove unused params from delete_resourcesDrew Walters
Parameters `release_name` and `name` are ignored by the Tiller handler's `delete_resources` method because the deletions are handled using labels rather than by name. Currently, values that do not represent the parameters are being passed to the method, which sometimes leads to cryptic logging messages. This change removes all references to the aforementioned parameters and clarifies the corresponding docstring and log message. Change-Id: Ic43819a273bf9da5e8965f409a56307eb11b4922 Notes (review): Code-Review+1: Andrey Volkov <av903u@att.com> Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Aaron Sheffield <ajs@sheffieldfamily.net> Workflow+1: Aaron Sheffield <ajs@sheffieldfamily.net> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 14 Nov 2018 19:37:33 +0000 Reviewed-on: https://review.openstack.org/617380 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-13Create Makefile target to install Helm binaryDimitrios Markou
In Makefile there is no target which actually installs Helm binary. Because of that the execution of the "make charts" target fails Story: 2004304 Change-Id: I16687802855e5fef63f69eeb365204fe064996a5 Signed-off-by: Dimitrios Markou <dm844v@att.com> Notes (review): Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+1: Andrey Volkov <av903u@att.com> Code-Review+2: Bryan Strassner <bryan.strassner@gmail.com> Workflow+1: Bryan Strassner <bryan.strassner@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 14 Nov 2018 15:28:45 +0000 Reviewed-on: https://review.openstack.org/616686 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-13Merge "Implement tiller gRPC channel clean up"Zuul
2018-11-12Add warnings for post upgrade actionsDrew Walters
Armada does not perform post upgrade actions. This change adds a warning to the documentation, comments, and output. Change-Id: I4d37406e13a44759861ea179d06b26831efe2ac8 Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 12 Nov 2018 21:58:41 +0000 Reviewed-on: https://review.openstack.org/617037 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-12Implement tiller gRPC channel clean upSean Eagan
We have seen issues with dangling threads in Armada. This is likely due to a bug [0] in the version of gRPC that we were pinned to. This patchset: - moves us to the latest versions of the gRPC python libraries which add a new `channel.close()` method to cleanup channels. - implements the python context manager api in the tiller handler - uses the context manager api to explicitly scope tiller channel creation and cleanup to each Armada API and CLI call. This also fixes a couples issues with error handling introduced in [1]. [0]: https://github.com/grpc/grpc/issues/14338 [1]: https://review.openstack.org/#/c/610384 Change-Id: I2577a20fc76c397aa33157dc12a0e1d36f49733e Notes (review): Code-Review+2: Bryan Strassner <bryan.strassner@gmail.com> Code-Review+1: Andrey Volkov <av903u@att.com> Code-Review+1: Kaspars Skels <kaspars.skels@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Tue, 13 Nov 2018 15:26:38 +0000 Reviewed-on: https://review.openstack.org/616680 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-08Minor: meaningful default labelRoman Gorshunov
Making default label meaningful and conformant to "key=value" requirement. Change-Id: I93e2254314775cd96d7eb31c6d696430c8871808 Notes (review): Code-Review+2: Matt McEuen <matt.mceuen@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Thu, 08 Nov 2018 19:06:02 +0000 Reviewed-on: https://review.openstack.org/616660 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-07Merge "wait: Remove test pods from wait"Zuul
2018-11-06wait: Remove test pods from waitDrew Walters
When waiting on resources that share labels with existing test pods, an upgrade can fail due to a wait operation on the existing test pods. This change skips wait operations on test resources by filtering them using Helm hooks. Change-Id: I465d3429216457ea8d088064cafa74b2b0d9b8cb Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Wed, 07 Nov 2018 17:50:13 +0000 Reviewed-on: https://review.openstack.org/614360 Project: openstack/airship-armada Branch: refs/heads/master
2018-11-05Merge "Add caching and cleanup of chart tarballs"Zuul