summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Eagan <sean.eagan@att.com>2019-02-05 14:11:18 -0600
committerSean Eagan <sean.eagan@att.com>2019-02-05 14:11:18 -0600
commit9e977f8fc5068c151bbe8b1f49f73944cce20926 (patch)
treec46c8dc200dc941dd503c221fff3b451b5b42e57
parent03dd1f27c1b0827c4a8d309a3b592acef5fde5aa (diff)
Fix log message guard
A generator expression was being checked for emptiness, which does not support that, hence the log message was being generated erroneously, so switched to using a list comprehension. Change-Id: I88459f120f1c69b3396db440146ca75e2a5471ca
Notes
Notes (review): Code-Review+1: Evgeniy L <eli@mirantis.com> Code-Review+1: Lev Morgan <morgan.lev@gmail.com> Code-Review+1: Drew Walters <drewwalters96@gmail.com> Code-Review+1: chittibabu <chittibabu1299@gmail.com> Code-Review+2: Scott Hussey <sthussey@att.com> Code-Review+1: Vladislav Kuzmin <vkuzmin@mirantis.com> Code-Review+1: Vladyslav Drok <vdrok@mirantis.com> Code-Review+2: Bryan Strassner <strassner.bryan@gmail.com> Workflow+1: Bryan Strassner <strassner.bryan@gmail.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Fri, 22 Feb 2019 18:18:22 +0000 Reviewed-on: https://review.openstack.org/635026 Project: openstack/airship-armada Branch: refs/heads/master
-rw-r--r--armada/handlers/test.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/armada/handlers/test.py b/armada/handlers/test.py
index 94c9479..eed628b 100644
--- a/armada/handlers/test.py
+++ b/armada/handlers/test.py
@@ -148,7 +148,7 @@ class Test(object):
148 } 148 }
149 149
150 pod_list = self.tiller.k8s.client.list_namespaced_pod(**list_args) 150 pod_list = self.tiller.k8s.client.list_namespaced_pod(**list_args)
151 test_pods = (pod for pod in pod_list.items if is_test_pod(pod)) 151 test_pods = [pod for pod in pod_list.items if is_test_pod(pod)]
152 152
153 if test_pods: 153 if test_pods:
154 LOG.info( 154 LOG.info(