summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDrew Walters <drewwalters96@gmail.com>2018-11-09 22:05:05 +0000
committerDrew Walters <drewwalters96@gmail.com>2018-11-12 21:19:16 +0000
commit4b76fda6b41a7face9bcb2970d9bb8407c8fac45 (patch)
tree4ebb3d6326f28a9615fd8caa41284b8bd0b34bd5
parent94df4daeb6b9e31fe8c6f7d4e0ac2745221797bc (diff)
Add warnings for post upgrade actions
Armada does not perform post upgrade actions. This change adds a warning to the documentation, comments, and output. Change-Id: I4d37406e13a44759861ea179d06b26831efe2ac8
Notes
Notes (review): Code-Review+2: Sean Eagan <sean.eagan@att.com> Code-Review+2: Scott Hussey <sthussey@att.com> Workflow+1: Scott Hussey <sthussey@att.com> Verified+2: Zuul Submitted-by: Zuul Submitted-at: Mon, 12 Nov 2018 21:58:41 +0000 Reviewed-on: https://review.openstack.org/617037 Project: openstack/airship-armada Branch: refs/heads/master
-rw-r--r--armada/handlers/chart_deploy.py2
-rw-r--r--armada/schemas/armada-chart-schema.yaml2
-rw-r--r--doc/source/operations/guide-build-armada-yaml.rst19
3 files changed, 9 insertions, 14 deletions
diff --git a/armada/handlers/chart_deploy.py b/armada/handlers/chart_deploy.py
index c7644dd..ab6965d 100644
--- a/armada/handlers/chart_deploy.py
+++ b/armada/handlers/chart_deploy.py
@@ -132,6 +132,8 @@ class ChartDeploy(object):
132 pre_actions = upgrade_pre 132 pre_actions = upgrade_pre
133 133
134 if not self.disable_update_post and upgrade_post: 134 if not self.disable_update_post and upgrade_post:
135 LOG.warning('Post upgrade actions are ignored by Armada'
136 'and will not affect deployment.')
135 post_actions = upgrade_post 137 post_actions = upgrade_post
136 138
137 try: 139 try:
diff --git a/armada/schemas/armada-chart-schema.yaml b/armada/schemas/armada-chart-schema.yaml
index 37e16cf..cde8921 100644
--- a/armada/schemas/armada-chart-schema.yaml
+++ b/armada/schemas/armada-chart-schema.yaml
@@ -146,6 +146,8 @@ data:
146 $ref: '#/definitions/hook_action' 146 $ref: '#/definitions/hook_action'
147 create: 147 create:
148 $ref: '#/definitions/hook_action' 148 $ref: '#/definitions/hook_action'
149 # TODO(drewwalters96): Armada ignores post-update actions. Remove them
150 # in future schemas.
149 post: 151 post:
150 type: object 152 type: object
151 additionalProperties: false 153 additionalProperties: false
diff --git a/doc/source/operations/guide-build-armada-yaml.rst b/doc/source/operations/guide-build-armada-yaml.rst
index 936f27e..65f6ac6 100644
--- a/doc/source/operations/guide-build-armada-yaml.rst
+++ b/doc/source/operations/guide-build-armada-yaml.rst
@@ -208,35 +208,26 @@ Test options to pass through directly to helm.
208 next upgrade. 208 next upgrade.
209 209
210 210
211Upgrade, Install - Pre or Post 211Upgrade - Pre
212^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 212^^^^^^^^^^^^^
213 213
214+-------------+----------+---------------------------------------------------------------+ 214+-------------+----------+---------------------------------------------------------------+
215| keyword | type | action | 215| keyword | type | action |
216+=============+==========+===============================================================+ 216+=============+==========+===============================================================+
217| pre | object | actions prior to updating/installing chart | 217| pre | object | actions performed prior to updating a release |
218+-------------+----------+---------------------------------------------------------------+
219| post | object | actions post updating/installing chart |
220+-------------+----------+---------------------------------------------------------------+ 218+-------------+----------+---------------------------------------------------------------+
221 219
222
223Upgrade - Actions 220Upgrade - Actions
224^^^^^^^^^^^^^^^^^ 221^^^^^^^^^^^^^^^^^
225 222
226+-------------+----------+---------------------------------------------------------------+ 223+-------------+----------+---------------------------------------------------------------+
227| keyword | type | action | 224| keyword | type | action |
228+=============+==========+===============================================================+ 225+=============+==========+===============================================================+
229| update | object | updates daemonsets in pre update actions | 226| update | object | update daemonsets in pre-upgrade update actions |
230+-------------+----------+---------------------------------------------------------------+ 227+-------------+----------+---------------------------------------------------------------+
231| delete | sequence | delete jobs in pre delete actions and child pods | 228| delete | sequence | delete jobs and pods in pre-upgrade delete actions |
232+-------------+----------+---------------------------------------------------------------+ 229+-------------+----------+---------------------------------------------------------------+
233 230
234
235.. note::
236
237 Update actions are performed in the pre/post sections of upgrade
238
239
240Upgrade - Actions - Update/Delete 231Upgrade - Actions - Update/Delete
241^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 232^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
242 233