airship
/
utils
Code Issues Proposed changes

Update patch set 8 

Patch Set 8:

(2 comments)

Drew, 

I addressed your comments.

Patch-set: 8
Label: Verified=0
This commit is contained in:
Gerrit User 21813 2018-11-27 21:11:00 +00:00 committed by Gerrit Code Review
parent e42c8c4f35
commit c6a7ad23b4
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
0c157b195dac6ac2248d67c878208031400a4764
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_24ef9e80",
"filename": "/COMMIT_MSG",
"patchSetId": 8
},
"lineNbr": 8,
"author": {
"id": 21813
},
"writtenOn": "2018-11-27T21:11:00Z",
"side": 1,
"message": "I believe that all changes should depend on gates (first one).\nIt is possible to make it separate but makes a little sense for me.",
"parentUuid": "3f79a3b5_830341bd",
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_4309a9d8",
@ -252,6 +270,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_647ef6c0",
"filename": "assets/nginx/blacklist.conf",
"patchSetId": 8
},
"lineNbr": 1,
"author": {
"id": 21813
},
"writtenOn": "2018-11-27T21:11:00Z",
"side": 1,
"message": "Added description for additional changes.",
"parentUuid": "3f79a3b5_e38d5536",
"range": {
"startLine": 1,
"startChar": 22,
"endLine": 1,
"endChar": 38
},
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_038bb121",