Update patch set 10
Patch Set 10: (2 comments) > > What is the point in not following helm-toolkit patterns from the > start? > > Just wanted to make it more clear and manageable for review. No > functional purpose. Can squash it if you think it's better. I agree with Scott; I think it would be easier to have one change with the chart in its final form. It's time consuming to test the chart at each change and verify that each commit works as intended. Patch-set: 10 Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
parent
e5bc27b9a5
commit
1b36a8acd1
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_839901d0",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T17:50:41Z",
|
||||
"side": 1,
|
||||
"message": "This is part of a change sequence. Please add:\n\n Depends-On: https://review.openstack.org/614043",
|
||||
"revId": "cd6bbe248cdac01c041eb40247e6973525ef572c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_badf9ed1",
|
||||
"filename": "Makefile",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 17,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T17:50:41Z",
|
||||
"side": 1,
|
||||
"message": "Will this repository only serve a single image? If it is to be expanded upon in the future, it should probably be set-up to handle multiple images.",
|
||||
"range": {
|
||||
"startLine": 17,
|
||||
"startChar": 0,
|
||||
"endLine": 17,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "cd6bbe248cdac01c041eb40247e6973525ef572c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue