Update patch set 8
Patch Set 8: Code-Review-1 (13 comments) Patch-set: 8 Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
Gerrit User 28618
Gerrit Code Review
parent
7742eff51c
commit
12dc768867
|
|
@ -0,0 +1,279 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_830341bd",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "Is there a reason why this change is part of a change sequence? It appears as though it could be submitted independently.",
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_4309a9d8",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 17,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "nit: snapshots",
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_03ef31fa",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "\"Packages can be blacklisted at runtime\"",
|
||||
"range": {
|
||||
"startLine": 23,
|
||||
"startChar": 2,
|
||||
"endLine": 23,
|
||||
"endChar": 40
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_c3bb79db",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 31,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "Is there documentation that exists for configuring miniMirror? I\u0027m not sure whether or not we should be maintaining documentation for miniMirror configuration.\n\nA documentation section for installing airship-utils charts seems more appropriate.",
|
||||
"range": {
|
||||
"startLine": 31,
|
||||
"startChar": 0,
|
||||
"endLine": 31,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_832ca149",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 35,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "nit: comma required here",
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e31a3517",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 40,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "Can you elaborate on this?",
|
||||
"range": {
|
||||
"startLine": 40,
|
||||
"startChar": 4,
|
||||
"endLine": 40,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_0318911c",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 44,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "nit: missing period",
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_63cce595",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "Is this a mirror URL? It would be helpful to specify.",
|
||||
"range": {
|
||||
"startLine": 59,
|
||||
"startChar": 20,
|
||||
"endLine": 59,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_c30db9db",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "s/an/a",
|
||||
"range": {
|
||||
"startLine": 59,
|
||||
"startChar": 17,
|
||||
"endLine": 59,
|
||||
"endChar": 19
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_83d10131",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 60,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "Should this be distribution?",
|
||||
"range": {
|
||||
"startLine": 60,
|
||||
"startChar": 45,
|
||||
"endLine": 60,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e3df9536",
|
||||
"filename": "README.md",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 60,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "for an or of an",
|
||||
"range": {
|
||||
"startLine": 60,
|
||||
"startChar": 34,
|
||||
"endLine": 60,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e38d5536",
|
||||
"filename": "assets/nginx/blacklist.conf",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 1,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "This seems out of the scope of this change, and there is no context for the change in the commit message.",
|
||||
"range": {
|
||||
"startLine": 1,
|
||||
"startChar": 22,
|
||||
"endLine": 1,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_038bb121",
|
||||
"filename": "tools/install_packages.sh",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 16,
|
||||
"author": {
|
||||
"id": 28618
|
||||
},
|
||||
"writtenOn": "2018-11-23T18:11:38Z",
|
||||
"side": 1,
|
||||
"message": "This seems out of the scope of this change, and there is no context for the change in the commit message.",
|
||||
"range": {
|
||||
"startLine": 12,
|
||||
"startChar": 0,
|
||||
"endLine": 16,
|
||||
"endChar": 4
|
||||
},
|
||||
"revId": "0c157b195dac6ac2248d67c878208031400a4764",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue