Update patch set 7

Patch Set 7: Code-Review-1 (7 comments) Patch-set: 7 Reviewer: Gerrit User 29624 <29624@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
2020-01-15 15:50:22 +00:00 · 2020-01-15 15:50:22 +00:00 · 6f53decbee
parent 5cd1f704ab
commit 6f53decbee
1 changed files with 165 additions and 0 deletions
--- a/165
+++ b/165
@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3fa7e38b_24b8b976",
+        "filename": "doc/source/docker_guide.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "parentheses or periods on the numbered list please.  both looks strange.",
+      "range": {
+        "startLine": 24,
+        "startChar": 0,
+        "endLine": 24,
+        "endChar": 3
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_e4caa117",
+        "filename": "doc/source/docker_guide.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "ensure",
+      "range": {
+        "startLine": 24,
+        "startChar": 40,
+        "endLine": 24,
+        "endChar": 46
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_64deb1dc",
+        "filename": "doc/source/docker_guide.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 27,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "Makefile",
+      "range": {
+        "startLine": 27,
+        "startChar": 15,
+        "endLine": 27,
+        "endChar": 23
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_64f7915c",
+        "filename": "doc/source/docker_guide.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 44,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "with the change to use an airship user instead of root it would be good to call out that mount locations must be mnt or another directory owned by the airship user.",
+      "range": {
+        "startLine": 44,
+        "startChar": 0,
+        "endLine": 44,
+        "endChar": 3
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_6449d1b6",
+        "filename": "doc/source/getting_started.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 123,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "parentheses not needed here.. looks strange in this section, and the other sections are inconsistent some are 1. others are 1)",
+      "range": {
+        "startLine": 123,
+        "startChar": 2,
+        "endLine": 123,
+        "endChar": 3
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_846ded30",
+        "filename": "doc/source/getting_started.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 127,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "Spyglass",
+      "range": {
+        "startLine": 127,
+        "startChar": 37,
+        "endLine": 127,
+        "endChar": 38
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fa7e38b_245c397f",
+        "filename": "doc/source/getting_started.rst",
+        "patchSetId": 7
+      },
+      "lineNbr": 131,
+      "author": {
+        "id": 29624
+      },
+      "writtenOn": "2020-01-15T15:50:22Z",
+      "side": 1,
+      "message": "Spyglass",
+      "range": {
+        "startLine": 131,
+        "startChar": 32,
+        "endLine": 131,
+        "endChar": 33
+      },
+      "revId": "50e6be9d2f8e86d854c1a1e4004274ce2b7b9516",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}