Update patch set 5

Patch Set 5: Code-Review-1

(6 comments)

Patch-set: 5
Label: Code-Review=-1
This commit is contained in:
Gerrit User 30173 2019-12-19 21:08:45 +00:00 committed by Gerrit Code Review
parent 5bb23de5bb
commit 5c690ab0a9
1 changed files with 142 additions and 0 deletions

View File

@ -0,0 +1,142 @@
{
"comments": [
{
"key": {
"uuid": "3fa7e38b_b3405034",
"filename": "doc/source/docker_guide.rst",
"patchSetId": 5
},
"lineNbr": 42,
"author": {
"id": 30173
},
"writtenOn": "2019-12-19T21:08:45Z",
"side": 1,
"message": "this can be simplified to mkdir -p ~/tmp/spyglass",
"range": {
"startLine": 42,
"startChar": 4,
"endLine": 42,
"endChar": 36
},
"revId": "686a465c3d2b9f37c8e438287a4a322c22a8ac95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_f35fa80d",
"filename": "doc/source/docker_guide.rst",
"patchSetId": 5
},
"lineNbr": 52,
"author": {
"id": 30173
},
"writtenOn": "2019-12-19T21:08:45Z",
"side": 1,
"message": "if they\u0027re indeed following this guide, the tmp folder can be written as ~/tmp/spyglass. also, why are you mounting the same point twice?",
"range": {
"startLine": 52,
"startChar": 7,
"endLine": 52,
"endChar": 15
},
"revId": "686a465c3d2b9f37c8e438287a4a322c22a8ac95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_b359302a",
"filename": "doc/source/docker_guide.rst",
"patchSetId": 5
},
"lineNbr": 53,
"author": {
"id": 30173
},
"writtenOn": "2019-12-19T21:08:45Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 53,
"startChar": 7,
"endLine": 53,
"endChar": 15
},
"revId": "686a465c3d2b9f37c8e438287a4a322c22a8ac95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_337c6070",
"filename": "doc/source/docker_guide.rst",
"patchSetId": 5
},
"lineNbr": 73,
"author": {
"id": 30173
},
"writtenOn": "2019-12-19T21:08:45Z",
"side": 1,
"message": "shouldn\u0027t this be ~/tmp/spyglass as above?",
"range": {
"startLine": 73,
"startChar": 7,
"endLine": 73,
"endChar": 17
},
"revId": "686a465c3d2b9f37c8e438287a4a322c22a8ac95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_33f1c001",
"filename": "doc/source/getting_started.rst",
"patchSetId": 5
},
"lineNbr": 127,
"author": {
"id": 30173
},
"writtenOn": "2019-12-19T21:08:45Z",
"side": 1,
"message": "does the double : render differently?",
"range": {
"startLine": 127,
"startChar": 45,
"endLine": 127,
"endChar": 47
},
"revId": "686a465c3d2b9f37c8e438287a4a322c22a8ac95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_f3d2485f",
"filename": "doc/source/index.rst",
"patchSetId": 5
},
"lineNbr": 37,
"author": {
"id": 30173
},
"writtenOn": "2019-12-19T21:08:45Z",
"side": 1,
"message": "shouldn\u0027t need this",
"range": {
"startLine": 37,
"startChar": 15,
"endLine": 37,
"endChar": 19
},
"revId": "686a465c3d2b9f37c8e438287a4a322c22a8ac95",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}