airship
/
specs
Code Issues Proposed changes

Update patch set 21 

Patch-set: 21
This commit is contained in:
Gerrit User 7185 2019-09-12 06:47:58 +00:00 committed by Gerrit Code Review
parent 927e718fc7
commit a9033687ca
1 changed files with 245 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

245
e0453343e60fe4edfde6a3d543bf6aa67aea2b1f
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"key": {
"uuid": "5faad753_bc447e1c",
"filename": "specs/2.x/approved/airshipctl_bootstrap_isogen.rst",
"patchSetId": 21
},
"lineNbr": 169,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Please disregard this proposal. That was quite an overthinking. We do not need custom CR for ephemeral node cloud init since all we need at a time of ISO builder is network info (which should be defined in a separate spec if needed) and K8s certificates (specifically for admin service account). Certificates suppose to be pre-generated. Additional files and k8s deployment steps should be the part of the container builder and will be hidden from end-user",
"range": {
"startLine": 109,
"startChar": 0,
"endLine": 169,
"endChar": 22
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_13b913cb",
@ -17,6 +40,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_7c3cc6be",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 13,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_13b913cb",
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_f0cf8dad",
@ -40,6 +81,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_1c4b5259",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 77,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_f0cf8dad",
"range": {
"startLine": 77,
"startChar": 44,
"endLine": 77,
"endChar": 51
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_86770403",
@ -63,6 +128,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_9c70a2a7",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 86,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_86770403",
"range": {
"startLine": 86,
"startChar": 58,
"endLine": 86,
"endChar": 75
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_10902943",
@ -86,6 +175,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_bc731eb1",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 88,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_10902943",
"range": {
"startLine": 84,
"startChar": 0,
"endLine": 88,
"endChar": 52
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_d08371cb",
@ -109,6 +222,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_bc5a3e27",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 102,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_d08371cb",
"range": {
"startLine": 102,
"startChar": 65,
"endLine": 102,
"endChar": 66
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_66668854",
@ -132,6 +269,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_9c574203",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 114,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_66668854",
"range": {
"startLine": 114,
"startChar": 11,
"endLine": 114,
"endChar": 29
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_f3aeb796",
@ -149,6 +310,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_7c65a6e0",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 119,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_f3aeb796",
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_e6511864",
@ -172,6 +351,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_3c316eed",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 192,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_e6511864",
"range": {
"startLine": 192,
"startChar": 47,
"endLine": 192,
"endChar": 48
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_26d5f0b9",
@ -195,6 +398,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_7c37e6e4",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 254,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_26d5f0b9",
"range": {
"startLine": 254,
"startChar": 53,
"endLine": 254,
"endChar": 60
},
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_b36fdf90",
@ -211,6 +438,24 @@
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5faad753_5c3c6ac7",
"filename": "specs/approved/airshipctl_bootstrap_image.rst",
"patchSetId": 21
},
"lineNbr": 280,
"author": {
"id": 7185
},
"writtenOn": "2019-09-12T06:47:58Z",
"side": 1,
"message": "Done",
"parentUuid": "5faad753_b36fdf90",
"revId": "e0453343e60fe4edfde6a3d543bf6aa67aea2b1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}