airship
/
specs
Code Issues Proposed changes

Update patch set 13 

Patch Set 13: Code-Review-1

(8 comments)

Patch-set: 13
Label: Code-Review=-1
This commit is contained in:
Gerrit User 28869 2019-06-25 21:21:35 +00:00 committed by Gerrit Code Review
parent fc35dc8057
commit 7a83fdbf8f
1 changed files with 178 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

178
0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_55909d43",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 11,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "unneeded white space",
"range": {
"startLine": 11,
"startChar": 7,
"endLine": 11,
"endChar": 8
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_28d56744",
@ -23,6 +46,138 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f53c3130",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 113,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "extra characters",
"range": {
"startLine": 113,
"startChar": 58,
"endLine": 113,
"endChar": 60
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_951e15b9",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 115,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "I don\u0027t think this option makes sense. If a user wants to know which plugins are available, he would simply run `airshipctl help`",
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_d556cd5c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 125,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "This may ready better as:\n\nA YAML configuration file describes location, ...",
"range": {
"startLine": 125,
"startChar": 0,
"endLine": 125,
"endChar": 45
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b549d9b7",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "implies",
"range": {
"startLine": 126,
"startChar": 87,
"endLine": 126,
"endChar": 95
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b51b19c8",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "whitespace",
"range": {
"startLine": 126,
"startChar": 106,
"endLine": 126,
"endChar": 107
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f5d8b1ef",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 126,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "*airshipctl*",
"range": {
"startLine": 126,
"startChar": 69,
"endLine": 126,
"endChar": 79
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3d4967b6",
@ -224,6 +379,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_7552813d",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 13
},
"lineNbr": 376,
"author": {
"id": 28869
},
"writtenOn": "2019-06-25T21:21:35Z",
"side": 1,
"message": "Unique",
"range": {
"startLine": 376,
"startChar": 3,
"endLine": 376,
"endChar": 10
},
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_634e5d39",